Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 187603009: Fix FileManagerFileTasksComplexTest.FindFileHandlerTasks test failing (Closed)

Created:
6 years, 9 months ago by Dmitry Polukhin
Modified:
6 years, 9 months ago
Reviewers:
Nikita (slow), oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Fix FileManagerFileTasksComplexTest.FindFileHandlerTasks test failing Test is failing because FileManagerFileTasksComplexTest.FindFileHandlerTasks doesn't initialize URL system request context. But URL fetch was started due to misprint. BUG=343589 TEST=unit_tests NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255218

Patch Set 1 #

Patch Set 2 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/chromeos/customization_document.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Polukhin
PTAL, it should fix the test.
6 years, 9 months ago (2014-03-05 21:20:37 UTC) #1
oshima
lgtm
6 years, 9 months ago (2014-03-05 21:27:19 UTC) #2
Dmitry Polukhin
The CQ bit was checked by dpolukhin@chromium.org
6 years, 9 months ago (2014-03-05 22:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/187603009/20001
6 years, 9 months ago (2014-03-05 22:48:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/187603009/20001
6 years, 9 months ago (2014-03-06 00:08:28 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 01:59:31 UTC) #6
Message was sent while issue was closed.
Change committed as 255218

Powered by Google App Engine
This is Rietveld 408576698