Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 187603007: Rename IDR_OMNIBOX_BORDER_AND_SHADOW_* to IDR_TEXTFIELD_*. (Closed)

Created:
6 years, 9 months ago by msw
Modified:
6 years, 9 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, Sebastien Gabriel
Visibility:
Public.

Description

Rename IDR_OMNIBOX_BORDER_AND_SHADOW_* to IDR_TEXTFIELD_*. Rename the IDRs and the image asset files. This is a followup fix requested of r254805. BUG=319103, 187485 TEST=none R=oshima@chromium.org TBR=oshima@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255143

Patch Set 1 #

Patch Set 2 : Rename IDR_OMNIBOX_BORDER_AND_SHADOW_* to IDR_TEXTFIELD_*. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
D chrome/app/theme/default_100_percent/common/omnibox_border_and_shadow_bottom.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_border_and_shadow_bottom_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_border_and_shadow_bottom_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_border_and_shadow_center.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_border_and_shadow_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_border_and_shadow_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_border_and_shadow_top.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_border_and_shadow_top_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_border_and_shadow_top_right.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/textfield_bottom.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/textfield_bottom_left.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/textfield_bottom_right.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/textfield_center.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/textfield_left.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/textfield_right.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/textfield_top.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/textfield_top_left.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/textfield_top_right.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_border_and_shadow_bottom.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_border_and_shadow_bottom_left.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_border_and_shadow_bottom_right.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_border_and_shadow_center.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_border_and_shadow_left.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_border_and_shadow_right.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_border_and_shadow_top.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_border_and_shadow_top_left.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_border_and_shadow_top_right.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/textfield_bottom.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/textfield_bottom_left.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/textfield_bottom_right.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/textfield_center.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/textfield_left.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/textfield_right.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/textfield_top.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/textfield_top_left.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/textfield_top_right.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
msw
Hey Scott and Oshima, take a look as you have time; landing.
6 years, 9 months ago (2014-03-05 20:47:40 UTC) #1
oshima
lgtm
6 years, 9 months ago (2014-03-05 20:55:32 UTC) #2
msw
6 years, 9 months ago (2014-03-05 21:03:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r255143 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698