ui/views/controls/menu/menu_runner_impl_cocoa.h - Issue 1876013002: Fixed potential crash on destroying MenuRunnerImplCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_runner_impl_cocoa.h

Issue 1876013002: Fixed potential crash on destroying MenuRunnerImplCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review fixes. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/menu_runner_impl_cocoa.h

diff --git a/ui/views/controls/menu/menu_runner_impl_cocoa.h b/ui/views/controls/menu/menu_runner_impl_cocoa.h

index f1ae21fb88dcafc44d935702a6f4e3945583cb04..ac5b263e2b472ded3d5db6e440aa62ee43e5e1ea 100644

--- a/ui/views/controls/menu/menu_runner_impl_cocoa.h

+++ b/ui/views/controls/menu/menu_runner_impl_cocoa.h

@@ -39,6 +39,9 @@ class VIEWS_EXPORT MenuRunnerImplCocoa : public MenuRunnerImplInterface {

// The Cocoa menu controller that this instance is bridging.

base::scoped_nsobject<MenuController> menu_controller_;

+ // Are we in run waiting for it to return?

+ bool running_;

// Set if |running_| and Release() has been invoked.

bool delete_after_run_;

« no previous file with comments | « ui/views/controls/menu/menu_runner_cocoa_unittest.mm ('k') | ui/views/controls/menu/menu_runner_impl_cocoa.mm » ('j') | no next file with comments »