Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal.html

Issue 1875903002: [DevTools] Better heuristic for detecting object literals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal.html b/third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal.html
index afa3fd3323873bab3bbdc89a6626eb73e2479249..ac1c2e5e596b74f1aad06b046e8a6a067178c5bf 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal.html
@@ -5,7 +5,22 @@
<script>
function test()
{
- var commands = ["{a:1, b:2}", "{a:1}", "{var a = 1; eval(\"{a :1, b:2 }\");}", "{ for (var i = 0; i < 5; ++i); }"];
+ var commands = [
+ "{a:1, b:2}",
+ "{a:1}",
+ "{var a = 1; eval(\"{ a:1, b:2 }\");}",
+ "{ for (var i = 0; i < 5; ++i); }",
+ "{ a: 4 }),({ b: 7 }",
+ "{ let a = 4; a; }",
+ "{ let a = 4; }; { let b = 5; };",
+ "{ a: 4 } + { a: 5 }",
+ "{ a: 4 }, { a: 5 }",
+
+ // Test that detection doesn't incur side effects.
+ "var foo = 4;",
+ "{ a: foo++ }",
+ "foo;"
+ ];
var current = -1;
loopOverCommands();
function loopOverCommands()

Powered by Google App Engine
This is Rietveld 408576698