[DevTools] Better heuristic for detecting object literals

third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 194 matching lines @@
     {
         if (!result)
             return;
 
         WebInspector.console.showPromise().then(reportUponEvaluation);
         function reportUponEvaluation()
         {
             target.consoleModel.dispatchEventToListeners(WebInspector.ConsoleModel.Events.CommandEvaluated, {result: result, wasThrown: wasThrown, text: text, commandMessage: commandMessage, exceptionDetails: exceptionDetails});
         }
     }
-    if (/^\s*\{/.test(text) && /\}\s*$/.test(text))
-        text = '(' + text + ')';
+
+    /**
+     * @param {string} code
+     * @suppress {uselessCode}

[dgozman, 2016/04/26 23:50:27]

What is this?

+     * @return {boolean}
+     */
+    function looksLikeAnObjectLiteral(code) {

[dgozman, 2016/04/26 23:50:27]

style: { on next line

+        // Only parenthesize what appears to be an object literal.
+        if (!(/^\s*\{/.test(code) && /\}\s*$/.test(code)))
+            return false;
+
+        try {
+            // Check if the code can be interpreted as an expression.
+            Function("return " + code + ";");
+
+            // No syntax error! Does it work parenthesized?
+            Function("(" + code + ")");
+
+            return true;
+        } catch (e) {
+            return false;
+        }
+    }
+    if (looksLikeAnObjectLiteral(text)) {
+        text = "(" + text + ")";
+        WebInspector.console.warn("Evaluating input as an expression.");

[dgozman, 2016/04/26 23:50:27]

I still don't agree with this. Let's extract this into a separate patch, where
we can discuss it. Improving the heuristic is worth on its own, so landing this
patch without warning would be really good.

+    }
     executionContext.evaluate(text, "console", !!useCommandLineAPI, false, false, true, printResult);
 
     WebInspector.userMetrics.actionTaken(WebInspector.UserMetrics.Action.ConsoleEvaluated);
 }
 
 WebInspector.ConsoleModel.clearConsole = function()
 {
     var targets = WebInspector.targetManager.targets();
     for (var i = 0; i < targets.length; ++i)
         targets[i].consoleModel.requestClearMessages();
@@ skipping 376 matching lines @@
         this.dispatchEventToListeners(WebInspector.ConsoleModel.Events.CommandEvaluated, event.data);
     },
 
     __proto__: WebInspector.Object.prototype
 }
 
 /**
  * @type {!WebInspector.MultitargetConsoleModel}
  */
 WebInspector.multitargetConsoleModel;