Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1875833002:
Build app_list_shower only if use_aura=1 (Closed)
|
Created:
4 years, 8 months ago by Corentin Wallez Modified:
4 years, 8 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBuild app_list_shower only if use_aura=1
This was being build on non-Android platforms and broke the Mac build.
Guard the build with use_aura=1 in Gyp, like it is in GN.
BUG=601932
TBR=thakis@chromium.org
NOTRY=true
Committed: https://crrev.com/736ad8abed54d7393cf672f4dbc2eea26e08bdcf
Cr-Commit-Position: refs/heads/master@{#386214}
Patch Set 1 #Patch Set 2 : Add TBR #Patch Set 3 : Add NOTRY #
Total comments: 1
Patch Set 4 : Move change from all build to gn migration #Patch Set 5 : Alphabetical order #Messages
Total messages: 23 (11 generated)
cwallez@chromium.org changed reviewers: + beaudoin@chromium.org, hans@chromium.org, thakis@chromium.org
The CQ bit was checked by cwallez@chromium.org
TBR, fixing the Mac bot compilation
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875833002/40001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2016/04/08 at 21:35:39, commit-bot wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. LGTM
lgtm
Description was changed from ========== Build app_list_shower only if use_aura=1 This was being build on non-Android platforms and broke the Mac build. Guard the build with use_aura=1 in Gyp, like it is in GN. BUG=601932 ========== to ========== Build app_list_shower only if use_aura=1 This was being built on non-Android platforms and broke the Mac build. Guard the build with use_aura=1 in Gyp, like it is in GN. BUG=601932 ==========
Description was changed from ========== Build app_list_shower only if use_aura=1 This was being built on non-Android platforms and broke the Mac build. Guard the build with use_aura=1 in Gyp, like it is in GN. BUG=601932 ========== to ========== Build app_list_shower only if use_aura=1 This was being build on non-Android platforms and broke the Mac build. Guard the build with use_aura=1 in Gyp, like it is in GN. BUG=601932 TBR=thakis@chromium.org NOTRY=true ==========
The CQ bit was checked by cwallez@chromium.org
mfomitchev fyi
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875833002/40001
The CQ bit was unchecked by cwallez@chromium.org
The CQ bit was checked by cwallez@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from beaudoin@chromium.org Link to the patchset: https://codereview.chromium.org/1875833002/#ps80001 (title: "Alphabetical order")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875833002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875833002/80001
mfomitchev@chromium.org changed reviewers: + mfomitchev@chromium.org
Not LGTM https://codereview.chromium.org/1875833002/diff/40001/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/1875833002/diff/40001/build/all.gyp#newcode247 build/all.gyp:247: '../ui/app_list/shower/app_list_shower.gyp:app_list_shower_unittests', This is a unit tests target, I don't think it should be built here. We are already including it for chromium_builder_tests (you can find it if you search this file).
On 2016/04/08 21:49:08, mfomitchev wrote: > Not LGTM > > https://codereview.chromium.org/1875833002/diff/40001/build/all.gyp > File build/all.gyp (right): > > https://codereview.chromium.org/1875833002/diff/40001/build/all.gyp#newcode247 > build/all.gyp:247: > '../ui/app_list/shower/app_list_shower.gyp:app_list_shower_unittests', > This is a unit tests target, I don't think it should be built here. We are > already including it for chromium_builder_tests (you can find it if you search > this file). Ok, I see this was fixed. LGTM now.
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Build app_list_shower only if use_aura=1 This was being build on non-Android platforms and broke the Mac build. Guard the build with use_aura=1 in Gyp, like it is in GN. BUG=601932 TBR=thakis@chromium.org NOTRY=true ========== to ========== Build app_list_shower only if use_aura=1 This was being build on non-Android platforms and broke the Mac build. Guard the build with use_aura=1 in Gyp, like it is in GN. BUG=601932 TBR=thakis@chromium.org NOTRY=true Committed: https://crrev.com/736ad8abed54d7393cf672f4dbc2eea26e08bdcf Cr-Commit-Position: refs/heads/master@{#386214} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/736ad8abed54d7393cf672f4dbc2eea26e08bdcf Cr-Commit-Position: refs/heads/master@{#386214} |
