Fix gesture detection for autofill popup.

Fix gesture detection for autofill popup.

BUG=346241
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255759

[Garrett Casto, 2014-03-06 00:06:18]

I spent some time trying to write a decent test for this, but didn't come up
with anything reasonable. It would be nice to have the interactive UI test
exercise this functionality, but it requires adding test specific hooks that
aren't very pretty.

[Evan Stade, 2014-03-06 01:17:13]

On 2014/03/06 00:06:18, Garrett Casto wrote:
> I spent some time trying to write a decent test for this, but didn't come up
> with anything reasonable. It would be nice to have the interactive UI test
> exercise this functionality, but it requires adding test specific hooks that
> aren't very pretty.

Can you do something in the mold of
TabDragControllerTest.GestureEndShouldEndDragTest?

[Garrett Casto, 2014-03-06 22:36:08]

On 2014/03/06 01:17:13, Evan Stade wrote:
> On 2014/03/06 00:06:18, Garrett Casto wrote:
> > I spent some time trying to write a decent test for this, but didn't come up
> > with anything reasonable. It would be nice to have the interactive UI test
> > exercise this functionality, but it requires adding test specific hooks that
> > aren't very pretty.
> 
> Can you do something in the mold of
> TabDragControllerTest.GestureEndShouldEndDragTest?

I was hoping to do something that didn't specifically call the gesture handler
itself but instead simulated the events using EventGenerator. Unfortunately I
wasn't able to get the targeting correct for reasons that are eluding me and the
TPMs are leaning on me to fix this. So if you have any insight on how to
correctly target the popup using EventGenerator that would be useful. Otherwise
the current test is better than nothing.

[Evan Stade, 2014-03-06 22:40:57]

lgtm

https://codereview.chromium.org/187583004/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc
(right):

https://codereview.chromium.org/187583004/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc:18:
using testing::ReturnRef;
I think these should go inside the anonymous namespace

https://codereview.chromium.org/187583004/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc:87: //
Expectations
nit: final period

https://codereview.chromium.org/187583004/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc:105: //
Tapping outside the bounds clears any selection
nit: final period

[Garrett Casto, 2014-03-06 23:00:36]

https://codereview.chromium.org/187583004/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc
(right):

https://codereview.chromium.org/187583004/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc:18:
using testing::ReturnRef;
On 2014/03/06 22:40:58, Evan Stade wrote:
> I think these should go inside the anonymous namespace

Done.

https://codereview.chromium.org/187583004/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc:87: //
Expectations
On 2014/03/06 22:40:58, Evan Stade wrote:
> nit: final period

Done.

https://codereview.chromium.org/187583004/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc:105: //
Tapping outside the bounds clears any selection
On 2014/03/06 22:40:58, Evan Stade wrote:
> nit: final period

Done.

[Garrett Casto, 2014-03-06 23:00:40]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-03-06 23:04:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gcasto@chromium.org/187583004/50001

[commit-bot: I haz the power, 2014-03-07 00:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 00:46:18]

Try jobs failed on following builders: mac_chromium_compile_dbg,
mac_chromium_rel

[Garrett Casto, 2014-03-07 01:20:12]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-03-07 01:45:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gcasto@chromium.org/187583004/50001

[commit-bot: I haz the power, 2014-03-07 04:18:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 04:18:49]

Try jobs failed on following builders: mac_chromium_compile_dbg,
mac_chromium_rel

[Garrett Casto, 2014-03-07 20:19:25]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-03-07 20:33:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gcasto@chromium.org/187583004/50001

[commit-bot: I haz the power, 2014-03-08 10:55:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gcasto@chromium.org/187583004/50001

[commit-bot: I haz the power, 2014-03-08 11:53:24]

Change committed as 255759