Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 187573009: Remove CERT_STATUS_WEAK_DH_KEY. A weak DH key is not a certificate error. (Closed)

Created:
6 years, 9 months ago by wtc
Modified:
6 years, 9 months ago
Reviewers:
agl, felt, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Remove CERT_STATUS_WEAK_DH_KEY. A weak DH key is not a certificate error. R=agl@chromium.org,felt@chromium.org,rsleevi@chromium.org BUG=348987 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255306

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M net/cert/cert_status_flags.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_status_flags.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
wtc
6 years, 9 months ago (2014-03-05 22:47:10 UTC) #1
agl
lgtm
6 years, 9 months ago (2014-03-05 22:50:07 UTC) #2
felt
for my reference, this means it'll be a generic net error now ?
6 years, 9 months ago (2014-03-05 23:33:30 UTC) #3
wtc
On 2014/03/05 23:33:30, felt wrote: > for my reference, this means it'll be a generic ...
6 years, 9 months ago (2014-03-06 00:08:57 UTC) #4
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 9 months ago (2014-03-06 00:09:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/187573009/20001
6 years, 9 months ago (2014-03-06 00:26:53 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:20:27 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275865
6 years, 9 months ago (2014-03-06 01:20:28 UTC) #8
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 9 months ago (2014-03-06 02:32:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/187573009/20001
6 years, 9 months ago (2014-03-06 02:52:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/187573009/20001
6 years, 9 months ago (2014-03-06 03:16:54 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:50:52 UTC) #12
Message was sent while issue was closed.
Change committed as 255306

Powered by Google App Engine
This is Rietveld 408576698