media/base/video_frame.cc - Issue 187573006: Allow wrapping a media::VideoFrame with a new view_rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/video_frame.cc

Issue 187573006: Allow wrapping a media::VideoFrame with a new view_rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Only allow sub rect of original view_rect. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/video_frame.cc

diff --git a/media/base/video_frame.cc b/media/base/video_frame.cc

index b3458a5954992b542094c217e46011d77576f7b5..30847fbb398dad6dabee9d9afba1ba3412f66915 100644

--- a/media/base/video_frame.cc

+++ b/media/base/video_frame.cc

@@ -180,9 +180,14 @@ scoped_refptr<VideoFrame> VideoFrame::WrapExternalYuvData(

// static

scoped_refptr<VideoFrame> VideoFrame::WrapVideoFrame(

const scoped_refptr<VideoFrame>& frame,

+ const gfx::Rect& visible_rect,

const base::Closure& no_longer_needed_cb) {

+ DCHECK(visible_rect.x() >= frame->visible_rect().x() &&

+ visible_rect.y() >= frame->visible_rect().y() &&

+ visible_rect.right() <= frame->visible_rect().right() &&

+ visible_rect.bottom() <= frame->visible_rect().bottom());

Ami GONE FROM CHROMIUM 2014/03/05 20:05:13 aka DCHECK(frame->visible_rect().Contains(visible_

perkj_chrome 2014/03/06 07:40:14 thanks.

scoped_refptr<VideoFrame> wrapped_frame(new VideoFrame(

- frame->format(), frame->coded_size(), frame->visible_rect(),

+ frame->format(), frame->coded_size(), visible_rect,

frame->natural_size(), frame->GetTimestamp(), frame->end_of_stream()));

for (size_t i = 0; i < NumPlanes(frame->format()); ++i) {

« no previous file with comments | « media/base/video_frame.h ('k') | media/base/video_frame_pool.cc » ('j') | no next file with comments »