Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 187573002: Revert "Reverting custom pseudo element". (Closed)

Created:
6 years, 9 months ago by tasak
Modified:
6 years, 9 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, watchdog-blink-watchlist_google.com, Inactive, rwlbuis
Visibility:
Public.

Description

Revert "Reverting custom pseudo element". This is not the same as a patch for just reverting r164153. To make a patch smaller, - Element IDL does not have webkitPseudo (not reverted). - pseudo() invokes shadowPseudoId() (the old code uses pseudo() in shadowPseudoId()). - setPseudo() also invokes setShadowPseudoId(). c.f. https://src.chromium.org/viewvc/blink?revision=164153&view=revision BUG=349144 TEST=fast/dom/shadow/pseudo-attribute-rendering.html,fast/dom/shadow/styling-pseudo-attribute.html,fast/dom/shadow/shadow-pseudo-id.html,fast/dom/shadow/pseudo-attribute.html,fast/dom/shadow/styling-pseudo-attribute-in-shadow.html,fast/dom/shadow/shadow-nested-pseudo-id.html,fast/dom/shadow/custom-pseudo-in-selector-api.html,fast/dom/shadow/pseudo-attribute-dynamic.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -9 lines) Patch
M LayoutTests/fast/dom/shadow/custom-pseudo-in-selector-api.html View 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/custom-pseudo-in-selector-api-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/pseudo-attribute.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/pseudo-attribute-dynamic.html View 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/pseudo-attribute-dynamic-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/pseudo-attribute-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/pseudo-attribute-rendering-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id.html View 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadow-pseudo-id.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadow-pseudo-id-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/styling-pseudo-attribute.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/styling-pseudo-attribute-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/styling-pseudo-attribute-in-shadow.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/styling-pseudo-attribute-in-shadow-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
tasak
6 years, 9 months ago (2014-03-05 09:23:57 UTC) #1
dglazkov
+esprehn
6 years, 9 months ago (2014-03-05 17:01:55 UTC) #2
dglazkov
lgtm
6 years, 9 months ago (2014-03-05 23:08:40 UTC) #3
esprehn
lgtm, lets just make sure we revert this asap after we merge.
6 years, 9 months ago (2014-03-05 23:13:10 UTC) #4
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-06 06:24:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/187573002/1
6 years, 9 months ago (2014-03-06 06:24:28 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 06:24:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink, win_blink_rel
6 years, 9 months ago (2014-03-06 06:24:46 UTC) #8
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-06 09:09:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/187573002/1
6 years, 9 months ago (2014-03-06 09:09:33 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 09:58:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-06 09:58:33 UTC) #12
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-06 11:52:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/187573002/1
6 years, 9 months ago (2014-03-06 11:52:50 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 11:53:37 UTC) #15
Message was sent while issue was closed.
Change committed as 168627

Powered by Google App Engine
This is Rietveld 408576698