Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: core/fxge/ge/fx_ge_text_embeddertest.cpp

Issue 1875673004: Fix integer issues leading to out of bounds access in fx_ge_text.cpp. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: fix naming Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fxge/ge/fx_ge_text.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxge/ge/fx_ge_text_embeddertest.cpp
diff --git a/core/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp b/core/fxge/ge/fx_ge_text_embeddertest.cpp
similarity index 51%
copy from core/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp
copy to core/fxge/ge/fx_ge_text_embeddertest.cpp
index 176c923372eeb344c58d83a792cf5f2aa36b5f39..045b6dc8690cbcfe36c0a4d98b9259a2d96c0113 100644
--- a/core/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp
+++ b/core/fxge/ge/fx_ge_text_embeddertest.cpp
@@ -1,16 +1,17 @@
-// Copyright 2015 PDFium Authors. All rights reserved.
+// Copyright 2016 PDFium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "testing/embedder_test.h"
#include "testing/gtest/include/gtest/gtest.h"
-class FPDFRenderPatternEmbeddertest : public EmbedderTest {};
+class FXGETextEmbedderTest : public EmbedderTest {};
-TEST_F(FPDFRenderPatternEmbeddertest, LoadError_547706) {
- // Test shading where object is a dictionary instead of a stream.
- EXPECT_TRUE(OpenDocument("bug_547706.pdf"));
+TEST_F(FXGETextEmbedderTest, BadItalic) {
+ // Shouldn't crash.
+ EXPECT_TRUE(OpenDocument("bug_601362.pdf"));
FPDF_PAGE page = LoadPage(0);
+ EXPECT_NE(nullptr, page);
FPDF_BITMAP bitmap = RenderPage(page);
FPDFBitmap_Destroy(bitmap);
UnloadPage(page);
« no previous file with comments | « core/fxge/ge/fx_ge_text.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698