Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1875663002:
support adding symlinks to zip files (Closed)
|
Created:
4 years, 8 months ago by Mostyn Bramley-Moore Modified:
4 years, 8 months ago CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionsupport adding symlinks to zip files
Add symlinks as symlinks to zip files, not their target
in place of the symlink.
Committed: https://crrev.com/a7da5525463f06dd692dfc4740b4aeb6ffc6f681
Cr-Commit-Position: refs/heads/master@{#386199}
Patch Set 1 #Patch Set 2 : check that src_path is not None #Messages
Total messages: 22 (10 generated)
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875663002/1
Description was changed from ========== support adding symlinks to zip files ========== to ========== support adding symlinks to zip files Add symlinks as symlinks to zip files, not their target in place of the symlink. ==========
mostynb@opera.com changed reviewers: + klundberg@chromium.org
@klundberg: please take a look at this small improvement: preserve symlinks when creating zip files.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875663002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
klundberg@chromium.org changed reviewers: + mikecase@chromium.org
I'm not working on this anymore. I was going to add jbudorick as reviewer but it looks like he is out for a while. Mike, can you please take a look at this? Or get somebody else to do so? Thanks!
On 2016/04/08 16:08:47, klundberg wrote: > I'm not working on this anymore. Would you like me to remove your username from the OWNERS file (in a separate CL) ?
On 2016/04/08 20:27:54, Mostyn Bramley-Moore wrote: > On 2016/04/08 16:08:47, klundberg wrote: > > I'm not working on this anymore. > > Would you like me to remove your username from the OWNERS file (in a separate > CL) ? Yes, please do. I'm actually surprised that I'm still in the OWNERS file.
lgtm
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875663002/20001
Message was sent while issue was closed.
Description was changed from ========== support adding symlinks to zip files Add symlinks as symlinks to zip files, not their target in place of the symlink. ========== to ========== support adding symlinks to zip files Add symlinks as symlinks to zip files, not their target in place of the symlink. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== support adding symlinks to zip files Add symlinks as symlinks to zip files, not their target in place of the symlink. ========== to ========== support adding symlinks to zip files Add symlinks as symlinks to zip files, not their target in place of the symlink. Committed: https://crrev.com/a7da5525463f06dd692dfc4740b4aeb6ffc6f681 Cr-Commit-Position: refs/heads/master@{#386199} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a7da5525463f06dd692dfc4740b4aeb6ffc6f681 Cr-Commit-Position: refs/heads/master@{#386199} |
