Dart VM: Simplify token positions in the translation of await.

Dart VM: Simplify token positions in the translation of await.

We can reuse the token position given by ST(node->token_pos()).  This
allows the token positions for the final result to fit the pattern
assumed by MakeName.

R=hausner@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/c33789c4f50e5236f9df2d0d327c9f3f395629ee

[Kevin Millikin (Google), 2016-04-08 07:47:23]

This was a smaller change than I thought it would be.

[hausner, 2016-04-08 16:43:36]

Does this CL compile? I may be missing something, but I expected a LoadLocalNode
being passed to MakeName().

https://codereview.chromium.org/1875643002/diff/1/runtime/vm/ast_transformer.cc
File runtime/vm/ast_transformer.cc (right):

https://codereview.chromium.org/1875643002/diff/1/runtime/vm/ast_transformer....
runtime/vm/ast_transformer.cc:150: AddNewTempVarToPreamble(transformed_expr,
token_pos);
Nit: indentation should be 4 spaces.

https://codereview.chromium.org/1875643002/diff/1/runtime/vm/ast_transformer....
runtime/vm/ast_transformer.cc:227: result_ = MakeName(result_param);
How does this work? result_param is a LocalVariable (line 141), not an AstNode,
as expected by MakeName().

[Kevin Millikin (Google), 2016-04-11 09:06:11]

You are right, that was inadvertent.  Please take another look.

[hausner, 2016-04-12 15:36:44]

LGTM.

[Kevin Millikin (Google), 2016-11-24 08:44:45]

Description was changed from

==========
Dart VM: Simplify token positions in the translation of await.

We can reuse the token position given by ST(node->token_pos()).  This
allows the token positions for the final result to fit the pattern
assumed by MakeName.

R=hausner@google.com
BUG=
==========

to

==========
Dart VM: Simplify token positions in the translation of await.

We can reuse the token position given by ST(node->token_pos()).  This
allows the token positions for the final result to fit the pattern
assumed by MakeName.

R=hausner@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/c33789c4f50e5236f9df2d0d327c9f3f395629ee
==========

[Kevin Millikin (Google), 2016-11-24 08:44:46]

Committed patchset #3 (id:40001) manually as
c33789c4f50e5236f9df2d0d327c9f3f395629ee (presubmit successful).