chromecast/media/cma/ipc_streamer/coded_frame_provider_host.cc - Issue 1875623002: Convert //chromecast from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/ipc_streamer/coded_frame_provider_host.cc

Issue 1875623002: Convert //chromecast from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/media/cma/ipc_streamer/coded_frame_provider_host.h ('k') | chromecast/media/cma/ipc_streamer/decoder_buffer_base_marshaller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/media/cma/ipc_streamer/coded_frame_provider_host.cc

diff --git a/chromecast/media/cma/ipc_streamer/coded_frame_provider_host.cc b/chromecast/media/cma/ipc_streamer/coded_frame_provider_host.cc

index f1e76a4d529cf962658ee43b22f3c4b06ca747bb..94c257a2363a23a13060fd2524d27053be4abda6 100644

--- a/chromecast/media/cma/ipc_streamer/coded_frame_provider_host.cc

+++ b/chromecast/media/cma/ipc_streamer/coded_frame_provider_host.cc

@@ -21,7 +21,7 @@ namespace chromecast {

namespace media {

CodedFrameProviderHost::CodedFrameProviderHost(

- scoped_ptr<MediaMessageFifo> media_message_fifo)

+ std::unique_ptr<MediaMessageFifo> media_message_fifo)

: fifo_(std::move(media_message_fifo)), weak_factory_(this) {

weak_this_ = weak_factory_.GetWeakPtr();

thread_checker_.DetachFromThread();

@@ -63,7 +63,7 @@ void CodedFrameProviderHost::ReadMessages() {

// Read messages until a frame is provided (i.e. not just the audio/video

// configurations).

while (!read_cb_.is_null()) {

- scoped_ptr<MediaMessage> msg(fifo_->Pop());

+ std::unique_ptr<MediaMessage> msg(fifo_->Pop());

if (!msg)

break;