Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromecast/crash/linux/dump_info_unittest.cc

Issue 1875623002: Convert //chromecast from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/dump_info.cc ('k') | chromecast/crash/linux/minidump_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/dump_info_unittest.cc
diff --git a/chromecast/crash/linux/dump_info_unittest.cc b/chromecast/crash/linux/dump_info_unittest.cc
index dfa7e5d63b221214bd5f24cc5c8176b1c4777f93..03c46e1c571170a511c268d6f8be21b2df0c00d5 100644
--- a/chromecast/crash/linux/dump_info_unittest.cc
+++ b/chromecast/crash/linux/dump_info_unittest.cc
@@ -12,41 +12,41 @@
namespace chromecast {
TEST(DumpInfoTest, EmptyStringIsNotValid) {
- scoped_ptr<DumpInfo> dump_info(CreateDumpInfo(""));
+ std::unique_ptr<DumpInfo> dump_info(CreateDumpInfo(""));
ASSERT_FALSE(dump_info->valid());
}
TEST(DumpInfoTest, TooFewFieldsIsNotValid) {
- scoped_ptr<DumpInfo> dump_info(CreateDumpInfo(
- "{"
- "\"name\": \"name\","
- "\"dump_time\" : \"2001-11-12 18:31:01\","
- "\"dump\": \"dump_string\""
- "}"));
+ std::unique_ptr<DumpInfo> dump_info(
+ CreateDumpInfo("{"
+ "\"name\": \"name\","
+ "\"dump_time\" : \"2001-11-12 18:31:01\","
+ "\"dump\": \"dump_string\""
+ "}"));
ASSERT_FALSE(dump_info->valid());
}
TEST(DumpInfoTest, BadTimeStringIsNotValid) {
- scoped_ptr<DumpInfo> info(CreateDumpInfo(
- "{"
- "\"name\": \"name\","
- "\"dump_time\" : \"Mar 23 2014 01:23:45\","
- "\"dump\": \"dump_string\","
- "\"uptime\": \"123456789\","
- "\"logfile\": \"logfile.log\""
- "}"));
+ std::unique_ptr<DumpInfo> info(
+ CreateDumpInfo("{"
+ "\"name\": \"name\","
+ "\"dump_time\" : \"Mar 23 2014 01:23:45\","
+ "\"dump\": \"dump_string\","
+ "\"uptime\": \"123456789\","
+ "\"logfile\": \"logfile.log\""
+ "}"));
ASSERT_FALSE(info->valid());
}
TEST(DumpInfoTest, AllRequiredFieldsIsValid) {
- scoped_ptr<DumpInfo> info(CreateDumpInfo(
- "{"
- "\"name\": \"name\","
- "\"dump_time\" : \"2001-11-12 18:31:01\","
- "\"dump\": \"dump_string\","
- "\"uptime\": \"123456789\","
- "\"logfile\": \"logfile.log\""
- "}"));
+ std::unique_ptr<DumpInfo> info(
+ CreateDumpInfo("{"
+ "\"name\": \"name\","
+ "\"dump_time\" : \"2001-11-12 18:31:01\","
+ "\"dump\": \"dump_string\","
+ "\"uptime\": \"123456789\","
+ "\"logfile\": \"logfile.log\""
+ "}"));
struct tm tm = {0};
tm.tm_isdst = 0;
tm.tm_sec = 1;
@@ -66,26 +66,26 @@ TEST(DumpInfoTest, AllRequiredFieldsIsValid) {
}
TEST(DumpInfoTest, EmptyProcessNameIsValid) {
- scoped_ptr<DumpInfo> dump_info(CreateDumpInfo(
- "{"
- "\"name\": \"\","
- "\"dump_time\" : \"2001-11-12 18:31:01\","
- "\"dump\": \"dump_string\","
- "\"uptime\": \"123456789\","
- "\"logfile\": \"logfile.log\""
- "}"));
+ std::unique_ptr<DumpInfo> dump_info(
+ CreateDumpInfo("{"
+ "\"name\": \"\","
+ "\"dump_time\" : \"2001-11-12 18:31:01\","
+ "\"dump\": \"dump_string\","
+ "\"uptime\": \"123456789\","
+ "\"logfile\": \"logfile.log\""
+ "}"));
ASSERT_TRUE(dump_info->valid());
}
TEST(DumpInfoTest, SomeRequiredFieldsEmptyIsValid) {
- scoped_ptr<DumpInfo> info(CreateDumpInfo(
- "{"
- "\"name\": \"name\","
- "\"dump_time\" : \"2001-11-12 18:31:01\","
- "\"dump\": \"\","
- "\"uptime\": \"\","
- "\"logfile\": \"\""
- "}"));
+ std::unique_ptr<DumpInfo> info(
+ CreateDumpInfo("{"
+ "\"name\": \"name\","
+ "\"dump_time\" : \"2001-11-12 18:31:01\","
+ "\"dump\": \"\","
+ "\"uptime\": \"\","
+ "\"logfile\": \"\""
+ "}"));
struct tm tm = {0};
tm.tm_isdst = 0;
tm.tm_sec = 1;
@@ -105,21 +105,21 @@ TEST(DumpInfoTest, SomeRequiredFieldsEmptyIsValid) {
}
TEST(DumpInfoTest, AllOptionalFieldsIsValid) {
- scoped_ptr<DumpInfo> info(CreateDumpInfo(
- "{"
- "\"name\": \"name\","
- "\"dump_time\" : \"2001-11-12 18:31:01\","
- "\"dump\": \"dump_string\","
- "\"uptime\": \"123456789\","
- "\"logfile\": \"logfile.log\","
- "\"suffix\": \"suffix\","
- "\"prev_app_name\": \"previous_app\","
- "\"cur_app_name\": \"current_app\","
- "\"last_app_name\": \"last_app\","
- "\"release_version\": \"RELEASE\","
- "\"build_number\": \"BUILD_NUMBER\","
- "\"reason\": \"foo\""
- "}"));
+ std::unique_ptr<DumpInfo> info(
+ CreateDumpInfo("{"
+ "\"name\": \"name\","
+ "\"dump_time\" : \"2001-11-12 18:31:01\","
+ "\"dump\": \"dump_string\","
+ "\"uptime\": \"123456789\","
+ "\"logfile\": \"logfile.log\","
+ "\"suffix\": \"suffix\","
+ "\"prev_app_name\": \"previous_app\","
+ "\"cur_app_name\": \"current_app\","
+ "\"last_app_name\": \"last_app\","
+ "\"release_version\": \"RELEASE\","
+ "\"build_number\": \"BUILD_NUMBER\","
+ "\"reason\": \"foo\""
+ "}"));
struct tm tm = {0};
tm.tm_isdst = 0;
tm.tm_sec = 1;
@@ -145,16 +145,16 @@ TEST(DumpInfoTest, AllOptionalFieldsIsValid) {
}
TEST(DumpInfoTest, SomeOptionalFieldsIsValid) {
- scoped_ptr<DumpInfo> info(CreateDumpInfo(
- "{"
- "\"name\": \"name\","
- "\"dump_time\" : \"2001-11-12 18:31:01\","
- "\"dump\": \"dump_string\","
- "\"uptime\": \"123456789\","
- "\"logfile\": \"logfile.log\","
- "\"suffix\": \"suffix\","
- "\"prev_app_name\": \"previous_app\""
- "}"));
+ std::unique_ptr<DumpInfo> info(
+ CreateDumpInfo("{"
+ "\"name\": \"name\","
+ "\"dump_time\" : \"2001-11-12 18:31:01\","
+ "\"dump\": \"dump_string\","
+ "\"uptime\": \"123456789\","
+ "\"logfile\": \"logfile.log\","
+ "\"suffix\": \"suffix\","
+ "\"prev_app_name\": \"previous_app\""
+ "}"));
struct tm tm = {0};
tm.tm_isdst = 0;
tm.tm_sec = 1;
@@ -177,21 +177,21 @@ TEST(DumpInfoTest, SomeOptionalFieldsIsValid) {
}
TEST(DumpInfoTest, ExtraFieldsIsNotValid) {
- scoped_ptr<DumpInfo> info(CreateDumpInfo(
- "{"
- "\"name\": \"name\","
- "\"dump_time\" : \"2001-11-12 18:31:01\","
- "\"dump\": \"dump_string\","
- "\"uptime\": \"123456789\","
- "\"logfile\": \"logfile.log\","
- "\"suffix\": \"suffix\","
- "\"prev_app_name\": \"previous_app\","
- "\"cur_app_name\": \"current_app\","
- "\"last_app_name\": \"last_app\","
- "\"release_version\": \"RELEASE\","
- "\"build_number\": \"BUILD_NUMBER\","
- "\"hello\": \"extra_field\""
- "}"));
+ std::unique_ptr<DumpInfo> info(
+ CreateDumpInfo("{"
+ "\"name\": \"name\","
+ "\"dump_time\" : \"2001-11-12 18:31:01\","
+ "\"dump\": \"dump_string\","
+ "\"uptime\": \"123456789\","
+ "\"logfile\": \"logfile.log\","
+ "\"suffix\": \"suffix\","
+ "\"prev_app_name\": \"previous_app\","
+ "\"cur_app_name\": \"current_app\","
+ "\"last_app_name\": \"last_app\","
+ "\"release_version\": \"RELEASE\","
+ "\"build_number\": \"BUILD_NUMBER\","
+ "\"hello\": \"extra_field\""
+ "}"));
ASSERT_FALSE(info->valid());
}
« no previous file with comments | « chromecast/crash/linux/dump_info.cc ('k') | chromecast/crash/linux/minidump_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698