Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Side by Side Diff: chromecast/crash/linux/minidump_writer_unittest.cc

Issue 1875623002: Convert //chromecast from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/crash/linux/minidump_writer.h"
6
5 #include <fstream> 7 #include <fstream>
8 #include <memory>
6 9
7 #include "base/base_paths.h" 10 #include "base/base_paths.h"
8 #include "base/bind.h" 11 #include "base/bind.h"
9 #include "base/files/file_path.h" 12 #include "base/files/file_path.h"
10 #include "base/files/file_util.h" 13 #include "base/files/file_util.h"
11 #include "base/macros.h" 14 #include "base/macros.h"
12 #include "base/memory/scoped_ptr.h"
13 #include "base/test/scoped_path_override.h" 15 #include "base/test/scoped_path_override.h"
14 #include "chromecast/base/scoped_temp_file.h" 16 #include "chromecast/base/scoped_temp_file.h"
15 #include "chromecast/crash/linux/crash_testing_utils.h" 17 #include "chromecast/crash/linux/crash_testing_utils.h"
16 #include "chromecast/crash/linux/dump_info.h" 18 #include "chromecast/crash/linux/dump_info.h"
17 #include "chromecast/crash/linux/minidump_generator.h" 19 #include "chromecast/crash/linux/minidump_generator.h"
18 #include "chromecast/crash/linux/minidump_writer.h"
19 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
20 21
21 namespace chromecast { 22 namespace chromecast {
22 namespace { 23 namespace {
23 24
24 const char kDumplogFile[] = "dumplog"; 25 const char kDumplogFile[] = "dumplog";
25 const char kLockfileName[] = "lockfile"; 26 const char kLockfileName[] = "lockfile";
26 const char kMetadataName[] = "metadata"; 27 const char kMetadataName[] = "metadata";
27 const char kMinidumpSubdir[] = "minidumps"; 28 const char kMinidumpSubdir[] = "minidumps";
28 29
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 } 70 }
70 71
71 FakeMinidumpGenerator fake_generator_; 72 FakeMinidumpGenerator fake_generator_;
72 base::FilePath minidump_dir_; 73 base::FilePath minidump_dir_;
73 base::FilePath dumplog_file_; 74 base::FilePath dumplog_file_;
74 base::FilePath lockfile_path_; 75 base::FilePath lockfile_path_;
75 base::FilePath metadata_path_; 76 base::FilePath metadata_path_;
76 77
77 private: 78 private:
78 base::ScopedTempDir fake_home_dir_; 79 base::ScopedTempDir fake_home_dir_;
79 scoped_ptr<base::ScopedPathOverride> home_; 80 std::unique_ptr<base::ScopedPathOverride> home_;
80 81
81 DISALLOW_COPY_AND_ASSIGN(MinidumpWriterTest); 82 DISALLOW_COPY_AND_ASSIGN(MinidumpWriterTest);
82 }; 83 };
83 84
84 TEST_F(MinidumpWriterTest, Write_FailsWithIncorrectMinidumpPath) { 85 TEST_F(MinidumpWriterTest, Write_FailsWithIncorrectMinidumpPath) {
85 MinidumpWriter writer(&fake_generator_, 86 MinidumpWriter writer(&fake_generator_,
86 "/path/to/wrong/dir", 87 "/path/to/wrong/dir",
87 MinidumpParams(), 88 MinidumpParams(),
88 base::Bind(&FakeDumpState)); 89 base::Bind(&FakeDumpState));
89 90
(...skipping 29 matching lines...) Expand all
119 120
120 TEST_F(MinidumpWriterTest, Write_FailsWithSubdirInCorrectPath) { 121 TEST_F(MinidumpWriterTest, Write_FailsWithSubdirInCorrectPath) {
121 MinidumpWriter writer(&fake_generator_, 122 MinidumpWriter writer(&fake_generator_,
122 dumplog_file_.Append("subdir/logfile").value(), 123 dumplog_file_.Append("subdir/logfile").value(),
123 MinidumpParams(), 124 MinidumpParams(),
124 base::Bind(&FakeDumpState)); 125 base::Bind(&FakeDumpState));
125 ASSERT_EQ(-1, writer.Write()); 126 ASSERT_EQ(-1, writer.Write());
126 } 127 }
127 128
128 } // namespace chromecast 129 } // namespace chromecast
OLDNEW
« no previous file with comments | « chromecast/crash/linux/dump_info_unittest.cc ('k') | chromecast/crash/linux/synchronized_minidump_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698