Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: src/builtins.h

Issue 1875583003: Separate CodeAssembler and CodeStubAssembler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix gn build Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/builtins.h
diff --git a/src/builtins.h b/src/builtins.h
index 75761edfaeeb05e69ce06f073c558275791ac230..926ec1b0e3bed8590717618b7a8bf25068f2aaf9 100644
--- a/src/builtins.h
+++ b/src/builtins.h
@@ -11,13 +11,9 @@
namespace v8 {
namespace internal {
-namespace compiler {
-
// Forward declarations.
class CodeStubAssembler;
-} // namespace compiler
-
// Specifies extra arguments required by a C++ builtin.
enum class BuiltinExtraArguments : uint8_t {
kNone = 0u,
@@ -588,11 +584,11 @@ class Builtins {
static void Generate_ArrayCode(MacroAssembler* masm);
// ES6 section 20.2.2.10 Math.ceil ( x )
- static void Generate_MathCeil(compiler::CodeStubAssembler* assembler);
+ static void Generate_MathCeil(CodeStubAssembler* assembler);
// ES6 section 20.2.2.11 Math.clz32 ( x )
- static void Generate_MathClz32(compiler::CodeStubAssembler* assembler);
+ static void Generate_MathClz32(CodeStubAssembler* assembler);
// ES6 section 20.2.2.16 Math.floor ( x )
- static void Generate_MathFloor(compiler::CodeStubAssembler* assembler);
+ static void Generate_MathFloor(CodeStubAssembler* assembler);
enum class MathMaxMinKind { kMax, kMin };
static void Generate_MathMaxMin(MacroAssembler* masm, MathMaxMinKind kind);
// ES6 section 20.2.2.24 Math.max ( value1, value2 , ...values )
@@ -604,11 +600,11 @@ class Builtins {
Generate_MathMaxMin(masm, MathMaxMinKind::kMin);
}
// ES6 section 20.2.2.28 Math.round ( x )
- static void Generate_MathRound(compiler::CodeStubAssembler* assembler);
+ static void Generate_MathRound(CodeStubAssembler* assembler);
// ES6 section 20.2.2.32 Math.sqrt ( x )
- static void Generate_MathSqrt(compiler::CodeStubAssembler* assembler);
+ static void Generate_MathSqrt(CodeStubAssembler* assembler);
// ES6 section 20.2.2.35 Math.trunc ( x )
- static void Generate_MathTrunc(compiler::CodeStubAssembler* assembler);
+ static void Generate_MathTrunc(CodeStubAssembler* assembler);
// ES6 section 20.1.1.1 Number ( [ value ] ) for the [[Call]] case.
static void Generate_NumberConstructor(MacroAssembler* masm);
@@ -616,18 +612,14 @@ class Builtins {
static void Generate_NumberConstructor_ConstructStub(MacroAssembler* masm);
// ES6 section 25.3.1.2 Generator.prototype.next ( value )
- static void Generate_GeneratorPrototypeNext(
- compiler::CodeStubAssembler* assembler);
+ static void Generate_GeneratorPrototypeNext(CodeStubAssembler* assembler);
// ES6 section 25.3.1.3 Generator.prototype.return ( value )
- static void Generate_GeneratorPrototypeReturn(
- compiler::CodeStubAssembler* assembler);
+ static void Generate_GeneratorPrototypeReturn(CodeStubAssembler* assembler);
// ES6 section 25.3.1.4 Generator.prototype.throw ( exception )
- static void Generate_GeneratorPrototypeThrow(
- compiler::CodeStubAssembler* assembler);
+ static void Generate_GeneratorPrototypeThrow(CodeStubAssembler* assembler);
// ES6 section 19.1.3.2 Object.prototype.hasOwnProperty
- static void Generate_ObjectHasOwnProperty(
- compiler::CodeStubAssembler* assembler);
+ static void Generate_ObjectHasOwnProperty(CodeStubAssembler* assembler);
static void Generate_StringConstructor(MacroAssembler* masm);
static void Generate_StringConstructor_ConstructStub(MacroAssembler* masm);

Powered by Google App Engine
This is Rietveld 408576698