Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1875553004: Exclude Save-Data from CORS Access-Control-Request-Headers (Closed)

Created:
4 years, 8 months ago by tbansal1
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, gavinp+loader_chromium.org, loading-reviews+fetch_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, Nate Chapin, tyoshino+watch_chromium.org, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Exclude Save-Data from CORS Access-Control-Request-Headers When data saver is enabled, and a cross-origin fetch by a webpage is intercepted by a serviceworker and the serviceworker does a fetch, the preflight request will have save-data added to Access-Control-Request-Headers. As a short-term fix save-data will be excluded from ACRH header. Later all simple headers will be excluded from ACRH header. https://github.com/whatwg/fetch/issues/249 https://crbug.com/601092 BUG=599704 Review URL: https://codereview.chromium.org/1859313002 Cr-Commit-Position: refs/heads/master@{#385637} (cherry picked from commit dcc9b2874edf8fd00070eb4f14176288535101a2) Committed: https://chromium.googlesource.com/chromium/src/+/58f95bf087d5077231a092c353af34a9b09d7a3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -4 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 3 chunks +78 lines, -0 lines 0 comments Download
A content/test/data/service_worker/fetch_cross_origin.html View 1 chunk +17 lines, -0 lines 0 comments Download
A + content/test/data/service_worker/fetch_event_respond_with_fetch.js View 1 chunk +2 lines, -4 lines 0 comments Download
M net/test/embedded_test_server/http_request.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/test/embedded_test_server/http_request.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
4 years, 8 months ago (2016-04-08 21:07:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58f95bf087d5077231a092c353af34a9b09d7a3c.

Powered by Google App Engine
This is Rietveld 408576698