Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 187553003: Clean up SkCanvas::clip* API (Closed)

Created:
6 years, 9 months ago by robertphillips
Modified:
6 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Now that the matching changes have landed in Chromium we can clean up the API on our side. Committed: http://code.google.com/p/skia/source/detail?r=13680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -28 lines) Patch
M include/core/SkCanvas.h View 3 chunks +12 lines, -16 lines 0 comments Download
M src/core/SkCanvas.cpp View 6 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 9 months ago (2014-03-05 20:53:09 UTC) #1
reed1
woot maybe we can try variants that don't have so many default args? lgtm
6 years, 9 months ago (2014-03-05 20:55:55 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 9 months ago (2014-03-06 12:54:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/187553003/1
6 years, 9 months ago (2014-03-06 12:54:13 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 13:18:45 UTC) #5
Message was sent while issue was closed.
Change committed as 13680

Powered by Google App Engine
This is Rietveld 408576698