Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1875523002: Fixed a crash in blimp toolbar (Closed)

Created:
4 years, 8 months ago by shaktisahu
Modified:
4 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed a crash in blimp toolbar On a slow device, sometimes onNewIntent is triggered even before the loading of libraries is completed. In that case blimp currently crashes while trying to load an URL since toolbar is not yet initialized. Fixed the crash by adding a null check. BUG=601226 Committed: https://crrev.com/daa11718e228d5eb00640e2716016b24d24187d0 Cr-Commit-Position: refs/heads/master@{#387045}

Patch Set 1 #

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
shaktisahu
4 years, 8 months ago (2016-04-07 23:33:48 UTC) #3
nyquist
So; this fixes the crash; but we lose the Intent that was being opened. Should ...
4 years, 8 months ago (2016-04-12 18:54:29 UTC) #5
shaktisahu
4 years, 8 months ago (2016-04-12 20:39:31 UTC) #6
nyquist
lgtm
4 years, 8 months ago (2016-04-13 17:50:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875523002/20001
4 years, 8 months ago (2016-04-13 17:50:53 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 18:39:45 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:41:57 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/daa11718e228d5eb00640e2716016b24d24187d0
Cr-Commit-Position: refs/heads/master@{#387045}

Powered by Google App Engine
This is Rietveld 408576698