Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1875503003: Revert "Create and pass shared-histogram-allocator from browser to renderer." (Closed)

Created:
4 years, 8 months ago by Yusuf
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Create and pass shared-histogram-allocator from browser to renderer." This reverts commit df016a7ce60decb9174ab2201bf4864fc7cefa82. BUG=601644 TBR=bcwhite@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3d56b69c397c7806b2441b0acfd2d98eb4c183ae Cr-Commit-Position: refs/heads/master@{#385930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -614 lines) Patch
M base/metrics/persistent_histogram_allocator.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/metrics/subprocess_metrics_provider.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/metrics/subprocess_metrics_provider.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/metrics/subprocess_metrics_provider_unittest.cc View 1 chunk +0 lines, -214 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/histogram_controller.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +0 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +0 lines, -37 lines 0 comments Download
M content/child/child_histogram_message_filter.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/child/child_histogram_message_filter.cc View 2 chunks +1 line, -18 lines 0 comments Download
M content/common/child_process_messages.h View 1 chunk +1 line, -9 lines 0 comments Download
M content/public/browser/render_process_host.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Yusuf
4 years, 8 months ago (2016-04-08 00:07:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875503003/1
4 years, 8 months ago (2016-04-08 00:09:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 00:10:53 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 00:12:05 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3d56b69c397c7806b2441b0acfd2d98eb4c183ae
Cr-Commit-Position: refs/heads/master@{#385930}

Powered by Google App Engine
This is Rietveld 408576698