chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc - Issue 1875443003: Retry uploading in UploadJobImpl when error occurs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

Issue 1875443003: Retry uploading in UploadJobImpl when error occurs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Retry when token request failed, add backoff, add log messages Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

diff --git a/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc b/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

index 0c9784cdd6e5233e2ad529761808d2ccd3fe65ba..edbe9e70aa3a3237f78e419fa42b9bc3e9eada3d 100644

--- a/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

+++ b/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.h"

#include "base/memory/ptr_util.h"

+#include "base/thread_task_runner_handle.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"

#include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"

@@ -59,7 +60,8 @@ std::unique_ptr<UploadJob> ScreenshotDelegate::CreateUploadJob(

return std::unique_ptr<UploadJob>(new UploadJobImpl(

upload_url, robot_account_id, device_oauth2_token_service,

system_request_context, delegate,

- base::WrapUnique(new UploadJobImpl::RandomMimeBoundaryGenerator)));

+ base::WrapUnique(new UploadJobImpl::RandomMimeBoundaryGenerator),

+ base::ThreadTaskRunnerHandle::Get()));

Andrew T Wilson (Slow) 2016/05/02 09:15:49 Why do we use this instead of blocking_task_runner

Marton Hunyady 2016/05/04 11:26:41 blocking_task_runner_ is used to store the screens

}

void ScreenshotDelegate::StoreScreenshot(

« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/system_log_uploader.cc » ('j') | chrome/browser/chromeos/policy/system_log_uploader.cc » ('J')