Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of https://codereview.chromium.org/1…

Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
>
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
>
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
>
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromium.org
BUG=596231, 601551
Review URL: https://codereview.chromium.org/1870633003 .

Cr-Commit-Position: refs/heads/master@{#385835}
(cherry picked from commit 0c6faeb81f1461952b5c63ad33e9fccc021a0c95)

Committed: https://chromium.googlesource.com/chromium/src/+/fbce535dd9db0b31583b0da338d86ee9d77f9b1e

[scottmg, 2016-04-07 19:33:33]

Description was changed from

==========
Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
>
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
>
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
>
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromiu...
BUG=596231, 601551

Review URL: https://codereview.chromium.org/1870633003 .

Cr-Commit-Position: refs/heads/master@{#385835}
(cherry picked from commit 0c6faeb81f1461952b5c63ad33e9fccc021a0c95)
==========

to

==========
Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
>
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
>
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
>
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromiu...
BUG=596231, 601551

Review URL: https://codereview.chromium.org/1870633003 .

Cr-Commit-Position: refs/heads/master@{#385835}
(cherry picked from commit 0c6faeb81f1461952b5c63ad33e9fccc021a0c95)

Committed:
https://chromium.googlesource.com/chromium/src/+/fbce535dd9db0b31583b0da338d8...
==========

[scottmg, 2016-04-07 19:33:37]

Committed patchset #1 (id:1) manually as
fbce535dd9db0b31583b0da338d86ee9d77f9b1e.