Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1875383002: VM: Fix status for test that is passing now. (Closed)

Created:
4 years, 8 months ago by Florian Schneider
Modified:
4 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, Bill Hesse
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix status for test that is passing now. The test started passing now. It was possibly failing because of a bug in older versions of MSVC. BUG=dartbug.com/24908 TBR=srdjan@google.com, Committed: https://github.com/dart-lang/sdk/commit/ee510ff0856cfdd1dbf3e40f57e5971b46ce5ef5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tests/lib/lib.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
Florian Schneider
TBR. @whesse: Did you by chance update MSVC on the Windows buildbots recently?
4 years, 8 months ago (2016-04-12 01:08:30 UTC) #4
Florian Schneider
4 years, 8 months ago (2016-04-12 01:09:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee510ff0856cfdd1dbf3e40f57e5971b46ce5ef5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698