Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1875373002: DevTools: split edit-dom-actions.html into three tests (Closed)

Created:
4 years, 8 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: split edit-dom-actions.html into three tests BUG=596486 R=dgozman Committed: https://crrev.com/b76bb4f8e43a33d87ac8ae3edbbdd3c5adf56fa8 Cr-Commit-Position: refs/heads/master@{#386792}

Patch Set 1 #

Patch Set 2 : split into two tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+568 lines, -460 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions.html View 1 chunk +0 lines, -298 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-1.html View 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-1-expected.txt View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-2.html View 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-2-expected.txt View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-3.html View 1 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-3-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-4.html View 1 1 chunk +111 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-4-expected.txt View 1 1 chunk +41 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-expected.txt View 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
lushnikov
ptal
4 years, 8 months ago (2016-04-12 00:38:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875373002/1
4 years, 8 months ago (2016-04-12 00:39:49 UTC) #4
dgozman
lgtm
4 years, 8 months ago (2016-04-12 00:52:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875373002/1
4 years, 8 months ago (2016-04-12 00:56:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/210716)
4 years, 8 months ago (2016-04-12 02:28:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875373002/1
4 years, 8 months ago (2016-04-12 02:59:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/210762)
4 years, 8 months ago (2016-04-12 05:11:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875373002/1
4 years, 8 months ago (2016-04-12 08:24:05 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/210833)
4 years, 8 months ago (2016-04-12 10:54:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875373002/20001
4 years, 8 months ago (2016-04-12 19:19:56 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 20:26:06 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 20:27:13 UTC) #25
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b76bb4f8e43a33d87ac8ae3edbbdd3c5adf56fa8
Cr-Commit-Position: refs/heads/master@{#386792}

Powered by Google App Engine
This is Rietveld 408576698