Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1875363003: Mark h/t/incremental/frame-focus-before-load.html as slow on all platforms. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
Reviewers:
beaudoin
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org, magjed_chromium, kuan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark h/t/incremental/frame-focus-before-load.html as slow on all platforms. This test has timed out recently on Site Isolation FYI bot [1] and takes around 2 seconds to run locally, so it seems we should 1. mark it as [ Slow ], not as [ Timeout ] 2. have the test expectation apply to all platforms (the FYI bot is Linux) [1] https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/8762 BUG=601726 TBR=beaudoin Committed: https://crrev.com/b9949a926f205a4c646bb187811b0ceff2b11af4 Cr-Commit-Position: refs/heads/master@{#386815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Łukasz Anforowicz
beaudoin@, could you please take a look when you have a chance? (I plan to ...
4 years, 8 months ago (2016-04-12 19:56:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875363003/1
4 years, 8 months ago (2016-04-12 20:02:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 21:24:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875363003/1
4 years, 8 months ago (2016-04-12 21:42:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 21:53:21 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 21:56:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9949a926f205a4c646bb187811b0ceff2b11af4
Cr-Commit-Position: refs/heads/master@{#386815}

Powered by Google App Engine
This is Rietveld 408576698