content/browser/shared_worker/shared_worker_host.cc - Issue 187533002: Add SharedWorkerServiceImpl::CheckWorkerDependency().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/shared_worker/shared_worker_host.cc

Issue 187533002: Add SharedWorkerServiceImpl::CheckWorkerDependency(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ExternalClient

Patch Set: incorporated kinuko's comment Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/message_port_message_filter.h ('k') | content/browser/shared_worker/shared_worker_message_filter.h » ('j') | content/browser/shared_worker/shared_worker_service_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/shared_worker/shared_worker_host.cc

diff --git a/content/browser/shared_worker/shared_worker_host.cc b/content/browser/shared_worker/shared_worker_host.cc

index 9d926cd18dfded3271d78b58038edd373f6f9cdb..25b8c9c779285988402f0faf4c79e7fa184a8751 100644

--- a/content/browser/shared_worker/shared_worker_host.cc

+++ b/content/browser/shared_worker/shared_worker_host.cc

@@ -135,7 +135,6 @@ void SharedWorkerHost::WorkerContextDestroyed() {

void SharedWorkerHost::WorkerScriptLoaded() {

// TODO(horo): implement this.

- NOTIMPLEMENTED();

}

void SharedWorkerHost::WorkerScriptLoadFailed() {