Source/core/loader/cache/CachedScript.cpp - Issue 18753002: Fix a warning from Clang's -Wlogical-not-parentheses: logical not used to be applied to the left ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/cache/CachedScript.cpp

Issue 18753002: Fix a warning from Clang's -Wlogical-not-parentheses: logical not used to be applied to the left ha… (Closed) Base URL: http://src.chromium.org/blink/trunk/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/cache/CachedScript.cpp

===================================================================

--- Source/core/loader/cache/CachedScript.cpp (revision 153522)

+++ Source/core/loader/cache/CachedScript.cpp (working copy)

@@ -86,7 +86,7 @@

bool CachedScript::mimeTypeAllowedByNosniff() const

{

- return !parseContentTypeOptionsHeader(m_response.httpHeaderField("X-Content-Type-Options")) == ContentTypeOptionsNosniff || MIMETypeRegistry::isSupportedJavaScriptMIMEType(mimeType());

+ return !(parseContentTypeOptionsHeader(m_response.httpHeaderField("X-Content-Type-Options")) == ContentTypeOptionsNosniff) || MIMETypeRegistry::isSupportedJavaScriptMIMEType(mimeType());

jochen (gone - plz use gerrit) 2013/07/05 07:43:12 why not just != ?

}

void CachedScript::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const

« no previous file with comments | « no previous file | no next file » | no next file with comments »