Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1875273002: [DevTools] Introduce a setting for console autocomplete from history. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce a setting for console autocomplete from history. BUG=602477 Committed: https://crrev.com/f7393c16130b5fd223aa4cb4ea41fcf672c623f8 Cr-Commit-Position: refs/heads/master@{#386571}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 2 chunks +9 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/console/module.json View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Could you please take a look? Hopefully, this would be merged to M50.
4 years, 8 months ago (2016-04-11 22:55:24 UTC) #2
lushnikov
thanks! LGTM https://codereview.chromium.org/1875273002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/1875273002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js#newcode144 third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:144: this._consoleHistoryAutocompleteSetting = WebInspector.moduleSetting("consoleHistoryAutocomplete"); nit: no need to ...
4 years, 8 months ago (2016-04-11 23:00:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875273002/1
4 years, 8 months ago (2016-04-12 00:49:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 03:38:31 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 03:39:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7393c16130b5fd223aa4cb4ea41fcf672c623f8
Cr-Commit-Position: refs/heads/master@{#386571}

Powered by Google App Engine
This is Rietveld 408576698