Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html

Issue 1875263005: [css-flexbox] More correctly implement percentage sizing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html
diff --git a/third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html b/third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html
index d78de16abd3972e0dda02cd73d333635917ccb03..9ab6f0720e57d5f7a07fe7b8c61969a1e8b6296c 100644
--- a/third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html
+++ b/third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html
@@ -31,22 +31,21 @@
<div id=log></div>
<p>This test verifies that we consider flex items' cross sizes to be definite
-iff the flexbox has a definite cross size, is single-line, and the align value
-is stretch (the default)</p>
+if the align value is stretch (the default)</p>
-<p>Tests that we get an indefinite size in the normal case.</p>
+<p>Tests that we get a definite size in the simple case.</p>
<div class="flexbox" data-expected-height="50">
<div data-expected-height="50">
- <div style="height: 50%" data-expected-height="50">
+ <div style="height: 50%" data-expected-height="25">
<div class="rect" data-expected-height="50"></div>
</div>
</div>
</div>
-<p>Tests that we get an indefinite size in a wrapping flexbox</p>
+<p>Tests that we get an definite size in a wrapping flexbox</p>
<div class="flexbox wrap" style="height: 50px;" data-expected-height="50">
<div data-expected-height="50">
- <div style="height: 50%" data-expected-height="50">
+ <div style="height: 50%" data-expected-height="25">
<div class="rect" data-expected-height="50"></div>
</div>
</div>
@@ -110,11 +109,11 @@ is stretch (the default)</p>
</div>
</div>
-<p>Tests that percentage sizes are not necessarily definite</p>
+<p>Tests that we use a definite size even when a percentage size is not definite</p>
<div>
<div class="flexbox" style="height: 10%;" data-expected-height="50">
<div data-expected-height="50">
- <div style="height: 50%" data-expected-height="50">
+ <div style="height: 50%" data-expected-height="25">
<div class="rect" data-expected-height="50"></div>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698