[Interpreter] Report hottest bytecodes in bytecode_dispatches_report.py

tools/ignition/bytecode_dispatches_report.py

 #! /usr/bin/python
 #
 # Copyright 2016 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 
 import argparse
 import heapq
 import json
@@ skipping 50 matching lines @@
                         key=lambda x: x[2])
 
 
 def print_top_counters(dispatches_table, top_count):
   top_counters = find_top_counters(dispatches_table, top_count)
   print "Top {} dispatch counters:".format(top_count)
   for source, destination, counter in top_counters:
     print "{:>12d}\t{} -> {}".format(counter, source, destination)
 
 
+def find_top_dispatch_sources(dispatches_table, top_count):
+  def dispatch_sources_counters_generator():
+    for source, counters_from_source in dispatches_table.items():
+      yield source, sum(counters_from_source.values())
+
+  return heapq.nlargest(top_count, dispatch_sources_counters_generator(),

[rmcilroy, 2016/04/13 08:45:54]

I would probably default to printing all the bytecodes for this mode instead of
a top x.

[Stefano Sanfilippo, 2016/04/13 10:19:38]

Done.

+                        key=lambda x: x[1])
+
+
+def print_top_dispatch_sources(dispatches_table, top_count):
+  top_dispatch_sources = find_top_dispatch_sources(dispatches_table, top_count)
+  print "Top {} dispatch sources:".format(top_count)

[rmcilroy, 2016/04/13 08:45:54]

Sources is not a good name since it isn't clear what that means except in the
context of bytecode->bytecode dispatches. Just top_bytecodes is fine. Also
rename the top_counters to top_bytecode_dispatches or similar.

[Stefano Sanfilippo, 2016/04/13 10:19:37]

Done.

+  for source, counter in top_dispatch_sources:
+    print "{:>12d}\t{}".format(counter, source)
+
+
 def build_counters_matrix(dispatches_table):
   labels = sorted(dispatches_table.keys())
 
   counters_matrix = numpy.empty([len(labels), len(labels)], dtype=int)
   for from_index, from_name in enumerate(labels):
     current_row = dispatches_table[from_name];
     for to_index, to_name in enumerate(labels):
       counters_matrix[from_index, to_index] = current_row.get(to_name, 0)
 
   # Reverse y axis for a nicer appearance
@@ skipping 98 matching lines @@
     figure, axis = pyplot.subplots()
     plot_dispatches_table(dispatches_table, figure, axis)
 
     if program_options.interactive:
       pyplot.show()
     else:
       figure.set_size_inches(program_options.plot_size,
                              program_options.plot_size)
       pyplot.savefig(program_options.output_filename)
   else:
+    print_top_dispatch_sources(dispatches_table, program_options.top_count)

[rmcilroy, 2016/04/13 08:45:54]

Please make this a separate option (and be the default, with top_dispatches as a
separate option). Also update the help text.

[Stefano Sanfilippo, 2016/04/13 10:19:37]

Done.

+    print  # just a blank line
     print_top_counters(dispatches_table, program_options.top_count)
 
 
 if __name__ == "__main__":
   main()