Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1875263003: [api] Introduce ReturnValue::Get (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Introduce ReturnValue::Get This is a convenience API that an embedder can use to do final checks on the return value. Note that this creates a new handle and thus defeats the performance optimization done for ReturnValue - an embedder should only use this in non-performance critical code paths. BUG= R=verwaest@chromium.org Committed: https://crrev.com/b3d793e48ab513b964d3e21be81f6b6713854ab2 Cr-Commit-Position: refs/heads/master@{#35409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M include/v8.h View 4 chunks +21 lines, -5 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-04-12 03:40:41 UTC) #1
Toon Verwaest
lgtm
4 years, 8 months ago (2016-04-12 08:29:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875263003/1
4 years, 8 months ago (2016-04-12 09:30:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 09:33:19 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 09:34:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3d793e48ab513b964d3e21be81f6b6713854ab2
Cr-Commit-Position: refs/heads/master@{#35409}

Powered by Google App Engine
This is Rietveld 408576698