Chromium Code Reviews| Index: scripts/slave/recipe_modules/bisect_tester/perf_test.py |
| diff --git a/scripts/slave/recipe_modules/bisect_tester/perf_test.py b/scripts/slave/recipe_modules/bisect_tester/perf_test.py |
| index 5cea5e7bd0915a962d2c811992a547dfdbb745dc..7126a3c21ed8d38c12570296df0c304edbc84003 100644 |
| --- a/scripts/slave/recipe_modules/bisect_tester/perf_test.py |
| +++ b/scripts/slave/recipe_modules/bisect_tester/perf_test.py |
| @@ -182,19 +182,22 @@ def find_values(results, metric): # pragma: no cover |
| results, metric.as_pair()) |
| return has_valid_value, value |
| +def _rebase_path(file_path): |
| + """Attempts to make a path relative src/out/Release""" |
| + if file_path.startswith('src/tools') or file_path.startswith(r'src\tools'): |
| + return os.path.join(os.pardir, os.pardir, os.pardir, file_path) |
| + return file_path |
| def _run_command(api, command, step_name): |
| - # TODO(robertocn): Reevaluate this approach when adding support for non-perf |
| - # tests and non-linux platforms. |
| - if api.m.platform.is_linux and 'xvfb' not in command: |
| - command = 'xvfb-run -a ' + command |
| command_parts = command.split() |
| stdout = api.m.raw_io.output() |
| stderr = api.m.raw_io.output() |
| try: |
| - step_result = api.m.step( |
| - step_name, |
| - command_parts, |
| + step_result = api.m.chromium.runtest( |
|
prasadv1
2016/04/21 19:51:54
I think we should include this change here
https:/
RobertoCN
2016/04/21 21:06:28
Done.
|
| + test=_rebase_path(command_parts[0]), |
| + args=command_parts[1:], |
| + xvfb=True, |
| + name=step_name, |
| stdout=stdout, |
| stderr=stderr) |
| step_result.presentation.logs['Captured Output'] = ( |