Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1875263002: Changing bisect_tester module to invoke run_test.py (Closed)

Created:
4 years, 8 months ago by RobertoCN
Modified:
4 years, 8 months ago
Reviewers:
prasadv1, prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Changing bisect_tester module to invoke run_test.py This is instead of calling the test command directly. One of the reasons for this is letting run_test deal with xvfb when appropriate. R=prasadv BUG=596214 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300093

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing path difference. #

Total comments: 2

Patch Set 3 : Rebased. #

Patch Set 4 : Retraining expectations after rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1950 lines, -329 lines) Patch
M scripts/slave/recipe_modules/bisect_tester/perf_test.py View 1 2 2 chunks +10 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_aosp_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_aosp_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_aosp_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_fyi_perf_bisect.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5X_perf_bisect.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5_perf_bisect.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus6_perf_bisect.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus9_perf_bisect.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_bisect.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_cq.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_aosp_perf_bisect.json View 2 chunks +32 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_aosp_perf_bisect.json View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_linux_bisect_tester_recipe.json View 1 2 2 chunks +28 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_linux_bisect_tester_recipe_ret_code.json View 1 2 2 chunks +28 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json View 1 2 2 chunks +30 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json View 1 2 2 chunks +30 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json View 1 2 2 chunks +30 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json View 1 2 2 chunks +30 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_linux_perf_bisector.json View 1 2 3 2 chunks +28 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_linux_perf_tester.json View 1 2 3 2 chunks +28 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win64_nv_tester.json View 1 2 3 2 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
RobertoCN
4 years, 8 months ago (2016-04-11 22:07:32 UTC) #1
prasadv
https://codereview.chromium.org/1875263002/diff/1/scripts/slave/recipe_modules/bisect_tester/perf_test.py File scripts/slave/recipe_modules/bisect_tester/perf_test.py (right): https://codereview.chromium.org/1875263002/diff/1/scripts/slave/recipe_modules/bisect_tester/perf_test.py#newcode194 scripts/slave/recipe_modules/bisect_tester/perf_test.py:194: xvfb=True, "xvfb=True", should this be set for all platforms?
4 years, 8 months ago (2016-04-11 22:30:53 UTC) #2
RobertoCN
On 2016/04/11 at 22:30:53, prasadv wrote: > https://codereview.chromium.org/1875263002/diff/1/scripts/slave/recipe_modules/bisect_tester/perf_test.py > File scripts/slave/recipe_modules/bisect_tester/perf_test.py (right): > > https://codereview.chromium.org/1875263002/diff/1/scripts/slave/recipe_modules/bisect_tester/perf_test.py#newcode194 ...
4 years, 8 months ago (2016-04-11 23:27:49 UTC) #3
RobertoCN
Ping
4 years, 8 months ago (2016-04-21 19:47:10 UTC) #4
prasadv1
Oops, sorry for the delay https://codereview.chromium.org/1875263002/diff/20001/scripts/slave/recipe_modules/bisect_tester/perf_test.py File scripts/slave/recipe_modules/bisect_tester/perf_test.py (right): https://codereview.chromium.org/1875263002/diff/20001/scripts/slave/recipe_modules/bisect_tester/perf_test.py#newcode196 scripts/slave/recipe_modules/bisect_tester/perf_test.py:196: step_result = api.m.chromium.runtest( I ...
4 years, 8 months ago (2016-04-21 19:51:54 UTC) #6
RobertoCN
https://codereview.chromium.org/1875263002/diff/20001/scripts/slave/recipe_modules/bisect_tester/perf_test.py File scripts/slave/recipe_modules/bisect_tester/perf_test.py (right): https://codereview.chromium.org/1875263002/diff/20001/scripts/slave/recipe_modules/bisect_tester/perf_test.py#newcode196 scripts/slave/recipe_modules/bisect_tester/perf_test.py:196: step_result = api.m.chromium.runtest( On 2016/04/21 19:51:54, prasadv1 wrote: > ...
4 years, 8 months ago (2016-04-21 21:06:28 UTC) #7
prasadv1
lgtm
4 years, 8 months ago (2016-04-21 21:08:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875263002/40001
4 years, 8 months ago (2016-04-21 21:09:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4218)
4 years, 8 months ago (2016-04-21 21:16:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875263002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875263002/60001
4 years, 8 months ago (2016-04-21 21:25:53 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 21:29:44 UTC) #17
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300093

Powered by Google App Engine
This is Rietveld 408576698