Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than base::StringToInt().

Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than base::StringToInt().

I don't believe this fixes any actual bug, since the caller is restricting input length and checking output range.

It should make it easier to reason about though, since the status_code field is now left as kInvalidStatusCode on failure, whereas before StringToInt() may have modified it.

BUG=596546
Committed: https://crrev.com/68da9c5135bad8ed4ed40cb95133d2c313e164a7
Cr-Commit-Position: refs/heads/master@{#386479}

[eroman, 2016-04-11 19:56:20]

Description was changed from

==========
Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than
base::StringToInt().

I don't believe this fixes any actual bug, since the caller is restricting input
length and checking output range.

BUG=596546
==========

to

==========
Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than
base::StringToInt().

I don't believe this fixes any actual bug, since the caller is restricting input
length and checking output range.

It should make it easier to reason about though, since the status_code field is
now left as kInvalidStatusCode on failure, whereas before ]StringToInt() may
have modified it.

BUG=596546
==========

[eroman, 2016-04-11 19:56:40]

Description was changed from

==========
Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than
base::StringToInt().

I don't believe this fixes any actual bug, since the caller is restricting input
length and checking output range.

It should make it easier to reason about though, since the status_code field is
now left as kInvalidStatusCode on failure, whereas before ]StringToInt() may
have modified it.

BUG=596546
==========

to

==========
Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than
base::StringToInt().

I don't believe this fixes any actual bug, since the caller is restricting input
length and checking output range.

It should make it easier to reason about though, since the status_code field is
now left as kInvalidStatusCode on failure, whereas before StringToInt() may have
modified it.

BUG=596546
==========

[eroman, 2016-04-11 19:56:49]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2016-04-11 21:00:32]

LGTM, yea, agree that this doesn't look to fix anything, and doesn't seem in
need of a new test, assuming the old testing here is sufficient.

[eroman, 2016-04-11 21:21:18]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2016-04-11 21:22:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1875203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1875203002/1

[commit-bot: I haz the power, 2016-04-11 21:36:35]

Description was changed from

==========
Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than
base::StringToInt().

I don't believe this fixes any actual bug, since the caller is restricting input
length and checking output range.

It should make it easier to reason about though, since the status_code field is
now left as kInvalidStatusCode on failure, whereas before StringToInt() may have
modified it.

BUG=596546
==========

to

==========
Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than
base::StringToInt().

I don't believe this fixes any actual bug, since the caller is restricting input
length and checking output range.

It should make it easier to reason about though, since the status_code field is
now left as kInvalidStatusCode on failure, whereas before StringToInt() may have
modified it.

BUG=596546
==========

[commit-bot: I haz the power, 2016-04-11 21:36:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-11 21:37:47]

Description was changed from

==========
Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than
base::StringToInt().

I don't believe this fixes any actual bug, since the caller is restricting input
length and checking output range.

It should make it easier to reason about though, since the status_code field is
now left as kInvalidStatusCode on failure, whereas before StringToInt() may have
modified it.

BUG=596546
==========

to

==========
Refactor FtpCtrlResponseBuffer::ParseLine to use net::ParseInt32() rather than
base::StringToInt().

I don't believe this fixes any actual bug, since the caller is restricting input
length and checking output range.

It should make it easier to reason about though, since the status_code field is
now left as kInvalidStatusCode on failure, whereas before StringToInt() may have
modified it.

BUG=596546

Committed: https://crrev.com/68da9c5135bad8ed4ed40cb95133d2c313e164a7
Cr-Commit-Position: refs/heads/master@{#386479}
==========

[commit-bot: I haz the power, 2016-04-11 21:37:48]

Patchset 1 (id:??) landed as
https://crrev.com/68da9c5135bad8ed4ed40cb95133d2c313e164a7
Cr-Commit-Position: refs/heads/master@{#386479}