Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 18751003: Calls to HCheckFunction can be eliminated if the value is an HConstant (Closed)

Created:
7 years, 5 months ago by mvstanton
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Calls to HCheckFunction can be eliminated if the value is an HConstant function, and that function handle matches the target handle. BUG= R=danno@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15540

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed two issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M src/hydrogen-instructions.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
LGTM, but please make sure that all the tests run and that the mozilla tests ...
7 years, 5 months ago (2013-07-05 12:57:33 UTC) #1
Michael Starzinger
Not looking good yet. https://codereview.chromium.org/18751003/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/18751003/diff/1/src/hydrogen-instructions.cc#newcode1695 src/hydrogen-instructions.cc:1695: HConstant::cast(value())->Hashcode() == target_unique_id_.Hashcode()) This might ...
7 years, 5 months ago (2013-07-05 13:09:06 UTC) #2
mvstanton
Michael, PTAL. Danno, I ran through Mozilla tests as well, successfully with the formulation of ...
7 years, 5 months ago (2013-07-08 08:43:05 UTC) #3
Michael Starzinger
LGTM.
7 years, 5 months ago (2013-07-08 08:59:39 UTC) #4
mvstanton
7 years, 5 months ago (2013-07-08 09:01:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r15540 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698