Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1875043003: Enable allocator shim for Android (Closed)

Created:
4 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Nico, DaleCurtis
CC:
chromium-reviews, DmitrySkiba, kraynov, ssid
Base URL:
https://chromium.googlesource.com/chromium/src.git@androidexp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable allocator shim for Android This is a follow-up to crrev.com/1719433002, which introduced the shim for Android, and enables it by default by setting use_experimental_allocator_shim=true for Android. Build/Perf sheriffs heads up ---------------------------- If you see any build error or crash related with __wrap_malloc, __wrap_free, __real_malloc, __real_free, etc this CL is to blame. Performance considerations ------------------------ Binary size diff (GN, arm, static, official build): 24k I did a mixture of local and trybots run to estimate the perf impact of this change. Didn't get any conclusive data, everything I tried seems in the same ballpark, below noise levels. More in details: cc_perftests.PrepareTiles on a Nexus 4. Rationale of the choice: in a previous CL (crbug.com/593344), this benchmark revealed the presence of two mfences in the malloc path. Results: https://goo.gl/8VC3Jp in the same ballpark. page-cycler on Nexus 9 via trybots: Results: http://goo.gl/J3i50a seems to suggest that this CL improves both warm and cold times in most cases. I doubt it, more likely it's noise. All the other perf trybots failed. The perf waterfall seems to be in a bad state in these days. BUG=550886, 598075 TEST=base_unittests --gtest_filter=AllocatorShimTest.* TBR=thakis@chromium.org Committed: https://crrev.com/ebb95496c73dc0d5ce83968ac619921f154305f7 Cr-Commit-Position: refs/heads/master@{#386386}

Patch Set 1 #

Patch Set 2 : Update README.md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/allocator/README.md View 1 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/allocator.gni View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (6 generated)
Primiano Tucci (use gerrit)
Nico, TBR-ing this as this is just split out of crrev.com/1719433002. Let's see how the ...
4 years, 8 months ago (2016-04-11 14:29:45 UTC) #3
Nico
lgtm
4 years, 8 months ago (2016-04-11 14:42:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875043003/20001
4 years, 8 months ago (2016-04-11 15:04:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 15:09:59 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ebb95496c73dc0d5ce83968ac619921f154305f7 Cr-Commit-Position: refs/heads/master@{#386386}
4 years, 8 months ago (2016-04-11 15:11:07 UTC) #10
DaleCurtis
I think this broke the Android clang build: In file included from ../../base/allocator/allocator_shim.cc:233: ../../base/allocator/allocator_shim_override_cpp_symbols.h:20:25: error: ...
4 years, 8 months ago (2016-04-11 17:52:34 UTC) #12
DaleCurtis
dcheck_always_on = true disable_incremental_isolated_processes = true enable_nacl = false target_os = "android" is_debug = false ...
4 years, 8 months ago (2016-04-11 17:53:30 UTC) #13
Nico
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1881523003/ by thakis@chromium.org. ...
4 years, 8 months ago (2016-04-11 18:11:14 UTC) #14
Nico
Huh weird, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/48480/steps/compile%20%28with%20patch%29/logs/stdio is happy. Maybe gn-specific? Anyhoo, reverted for now.
4 years, 8 months ago (2016-04-11 18:11:33 UTC) #15
DaleCurtis
Sheriff says primiano@ is on the fix, clang bots build with allocator disabled for asan.
4 years, 8 months ago (2016-04-11 18:12:15 UTC) #16
Primiano Tucci (use gerrit)
On 2016/04/11 18:12:15, DaleCurtis wrote: > Sheriff says primiano@ is on the fix, clang bots ...
4 years, 8 months ago (2016-04-11 18:19:53 UTC) #17
Primiano Tucci (use gerrit)
4 years, 8 months ago (2016-04-11 18:49:42 UTC) #18
Message was sent while issue was closed.
Reland w/ fix coming in https://codereview.chromium.org/1875173002/

Powered by Google App Engine
This is Rietveld 408576698