chrome/browser/download/download_ui_controller_unittest.cc - Issue 1875033005: [Downloads/History] Add tab-url and tab-referrer-url to DownloadRow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 1875033005: [Downloads/History] Add tab-url and tab-referrer-url to DownloadRow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guid-fix

Patch Set: Update expectations for DownloadUIController test. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_history_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_ui_controller_unittest.cc

diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc

index f5452ced88e7a9784e973e37bbcfae261a1ff712..51e9c0a1afdd3ba053ae7b7764ae675d73716e8b 100644

--- a/chrome/browser/download/download_ui_controller_unittest.cc

+++ b/chrome/browser/download/download_ui_controller_unittest.cc

@@ -221,6 +221,10 @@ DownloadUIControllerTest::CreateMockInProgressDownload() {

.WillRepeatedly(testing::ReturnRefOfCopy(std::vector<GURL>()));

EXPECT_CALL(*item, GetReferrerUrl())

.WillRepeatedly(testing::ReturnRefOfCopy(GURL()));

+ EXPECT_CALL(*item, GetTabUrl())

+ .WillRepeatedly(testing::ReturnRefOfCopy(GURL()));

+ EXPECT_CALL(*item, GetTabReferrerUrl())

+ .WillRepeatedly(testing::ReturnRefOfCopy(GURL()));

EXPECT_CALL(*item, GetStartTime()).WillRepeatedly(Return(base::Time()));

EXPECT_CALL(*item, GetEndTime()).WillRepeatedly(Return(base::Time()));

EXPECT_CALL(*item, GetETag()).WillRepeatedly(ReturnRefOfCopy(std::string()));