Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2613)

Unified Diff: runtime/vm/debugger.cc

Issue 18750004: Faster invocation of fields as methods. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 24991)
+++ runtime/vm/debugger.cc (working copy)
@@ -935,15 +935,20 @@
Context& ctx = Context::Handle(isolate->top_context());
Code& code = Code::Handle(isolate);
StackFrameIterator iterator(false);
- StackFrame* frame = iterator.NextFrame();
ActivationFrame* callee_activation = NULL;
bool optimized_frame_found = false;
- while (frame != NULL) {
+ for (StackFrame* frame = iterator.NextFrame();
+ frame != NULL;
+ frame = iterator.NextFrame()) {
ASSERT(frame->IsValid());
if (frame->IsDartFrame()) {
code = frame->LookupDartCode();
ActivationFrame* activation =
new ActivationFrame(frame->pc(), frame->fp(), frame->sp(), code);
+ // Check if frame is a debuggable function.
+ if (!IsDebuggable(activation->function())) {
+ continue;
+ }
// If this activation frame called a closure, the function has
// saved its context before the call.
if ((callee_activation != NULL) &&
@@ -980,7 +985,6 @@
ctx = reinterpret_cast<EntryFrame*>(frame)->SavedContext();
callee_activation = NULL;
}
- frame = iterator.NextFrame();
}
return stack_trace;
}
@@ -1534,7 +1538,8 @@
(fkind == RawFunction::kImplicitSetter) ||
(fkind == RawFunction::kConstImplicitGetter) ||
(fkind == RawFunction::kMethodExtractor) ||
- (fkind == RawFunction::kNoSuchMethodDispatcher)) {
+ (fkind == RawFunction::kNoSuchMethodDispatcher) ||
+ (fkind == RawFunction::kInvokeFieldDispatcher)) {
return false;
}
const Class& cls = Class::Handle(func.Owner());
« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698