Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1996)

Unified Diff: content/renderer/render_view_impl.cc

Issue 18750003: Require ACK for editor-related changes not originating from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 5ac2c12fddebfd4551d6d4c5af4a86d01677e8b4..967bb59f20ce0d30abcc8177e33028eafc96b2d9 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1727,6 +1727,8 @@ void RenderViewImpl::OnSetName(const std::string& name) {
void RenderViewImpl::OnSetEditableSelectionOffsets(int start, int end) {
base::AutoReset<bool> handling_select_range(&handling_select_range_, true);
+ if (!ShouldHandleImeEvent())
+ return;
ImeEventGuard guard(this);
webview()->setEditableSelectionOffsets(start, end);
}
@@ -1734,14 +1736,14 @@ void RenderViewImpl::OnSetEditableSelectionOffsets(int start, int end) {
void RenderViewImpl::OnSetCompositionFromExistingText(
int start, int end,
const std::vector<WebKit::WebCompositionUnderline>& underlines) {
- if (!webview())
+ if (!ShouldHandleImeEvent())
return;
ImeEventGuard guard(this);
webview()->setCompositionFromExistingText(start, end, underlines);
}
void RenderViewImpl::OnExtendSelectionAndDelete(int before, int after) {
- if (!webview())
+ if (!ShouldHandleImeEvent())
return;
ImeEventGuard guard(this);
webview()->extendSelectionAndDelete(before, after);
@@ -2360,7 +2362,7 @@ void RenderViewImpl::didChangeSelection(bool is_empty_selection) {
SyncSelectionIfRequired();
UpdateTextInputType();
#if defined(OS_ANDROID)
- UpdateTextInputState(DO_NOT_SHOW_IME);
+ UpdateTextInputState(false, true);
#endif
}
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698