Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 18750003: Require ACK for editor-related changes not originating from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/view_messages.h » ('j') | content/renderer/render_widget.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 806f35ff2fc5e6e4a10c1d38363f3e69992e3887..024f1fcabc66ac83417494bda3276903184dc11f 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -75,6 +75,11 @@ void InsertSyncPointAndAckForCompositor(
route_id, output_surface_id, renderer_host_id, ack);
}
+// Sends an acknowledgement to the renderer of a processed IME event.
+void SendImeEventAck(RenderWidgetHostImpl* host) {
+ host->Send(new ViewMsg_ImeEventAck(host->GetRoutingID()));
+}
+
} // anonymous namespace
RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid(
@@ -395,6 +400,13 @@ int RenderWidgetHostViewAndroid::GetNativeImeAdapter() {
void RenderWidgetHostViewAndroid::OnTextInputStateChanged(
const ViewHostMsg_TextInputState_Params& params) {
+#if defined(OS_ANDROID)
+ if (params.require_ack) {
+ // Regardless of how we exit from this method, we must acknowledge that we
+ // processed the input state change.
+ base::ScopedClosureRunner ackCaller(base::Bind(&SendImeEventAck, host_));
+ }
+#endif
if (!IsShowing())
return;
« no previous file with comments | « no previous file | content/common/view_messages.h » ('j') | content/renderer/render_widget.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698