Require ACK for editor-related changes not originating from browser.

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 59 matching lines @@
   if (!return_mailbox.IsZero()) {
     ack.gl_frame_data->mailbox = return_mailbox;
     ack.gl_frame_data->size = return_size;
     ack.gl_frame_data->sync_point =
         ImageTransportFactoryAndroid::GetInstance()->InsertSyncPoint();
   }
   RenderWidgetHostImpl::SendSwapCompositorFrameAck(
       route_id, output_surface_id, renderer_host_id, ack);
 }
 
+// Sends an acknowledgement to the renderer of a processed IME event.
+void SendImeEventAck(RenderWidgetHostImpl* host) {
+  host->Send(new ViewMsg_ImeEventAck(host->GetRoutingID()));
+}
+
 }  // anonymous namespace
 
 RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid(
     RenderWidgetHostImpl* widget_host,
     ContentViewCoreImpl* content_view_core)
     : host_(widget_host),
       needs_begin_frame_(false),
       are_layers_attached_(true),
       content_view_core_(NULL),
       ime_adapter_android_(this),
@@ skipping 301 matching lines @@
     ui::TextInputMode input_mode) {
   // Unused on Android, which uses OnTextInputChanged instead.
 }
 
 int RenderWidgetHostViewAndroid::GetNativeImeAdapter() {
   return reinterpret_cast<int>(&ime_adapter_android_);
 }
 
 void RenderWidgetHostViewAndroid::OnTextInputStateChanged(
     const ViewHostMsg_TextInputState_Params& params) {
+#if defined(OS_ANDROID)
+  if (params.require_ack) {
+    // Regardless of how we exit from this method, we must acknowledge that we
+    // processed the input state change.
+    base::ScopedClosureRunner ackCaller(base::Bind(&SendImeEventAck, host_));

[jam, 2013/08/01 22:34:07]

nit: ack_caller per style guide

btw never saw ScopedClosureRunner before, cool!

[nyquist, 2013/08/01 23:11:04]

Done.

Yeah, the ScopedClosureRunner is neat.

+  }
+#endif
   if (!IsShowing())
     return;
 
   content_view_core_->UpdateImeAdapter(
       GetNativeImeAdapter(),
       static_cast<int>(params.type),
       params.value, params.selection_start, params.selection_end,
       params.composition_start, params.composition_end,
       params.show_ime_if_needed);
 }
@@ skipping 733 matching lines @@
 // RenderWidgetHostView, public:
 
 // static
 RenderWidgetHostView*
 RenderWidgetHostView::CreateViewForWidget(RenderWidgetHost* widget) {
   RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(widget);
   return new RenderWidgetHostViewAndroid(rwhi, NULL);
 }
 
 } // namespace content