Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 18750002: Prepare push to trunk. Now working on version 3.20.3. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.20.3. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M ChangeLog View 1 chunk +20 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
7 years, 5 months ago (2013-07-05 07:01:49 UTC) #1
Hannes Payer (out of office)
LGTM
7 years, 5 months ago (2013-07-05 07:03:11 UTC) #2
Michael Achenbach
Committed patchset #1 manually as r15497 (presubmit successful).
7 years, 5 months ago (2013-07-05 07:05:17 UTC) #3
Jakob Kummerow
7 years, 5 months ago (2013-07-05 08:04:53 UTC) #4
Message was sent while issue was closed.
It's too late now, but we generally prefer the past tense for ChangeLog entries
describing what we did ("Removed", "Fixed", etc).

Powered by Google App Engine
This is Rietveld 408576698