Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1874983005: [Media Router WebUI] Fix whitespace in filter when no devices present. (Closed)

Created:
4 years, 8 months ago by btolsch
Modified:
4 years, 8 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Fix whitespace in filter when no devices present. This change adds whitespace below the filter input in the filter view when there are no devices to show for the current cast mode. In this case, the filter input is still at the bottom of the dialog and needs to be padded as such. This change also fixes an incorrect type annotation. BUG=602042 R=apacible@chromium.org Committed: https://crrev.com/bd1c2db6a90b98e180fe138fb9501cf8a1b5d942 Cr-Commit-Position: refs/heads/master@{#386627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 4 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
btolsch
Fixing whitespace. PTAL, thanks!
4 years, 8 months ago (2016-04-11 19:29:48 UTC) #1
apacible
lgtm
4 years, 8 months ago (2016-04-11 21:05:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874983005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874983005/1
4 years, 8 months ago (2016-04-12 08:15:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 08:36:39 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 08:38:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd1c2db6a90b98e180fe138fb9501cf8a1b5d942
Cr-Commit-Position: refs/heads/master@{#386627}

Powered by Google App Engine
This is Rietveld 408576698