Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 1874973003: [test] Simplify progress indicators. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Simplify progress indicators. This removes the "AboutToRun" callback. It makes not much sense as it is not actually called before a test is run, but just before the results are retrieved from the results queue. Therefore, from an information-value p-o-v it is redundant to the "HasRun" callback. This also reduces log size on the bots by 50%, in order to reduce buildbot slowness, which is tied to the amount of logs. Committed: https://crrev.com/af1f78b80e083dc05a8632a804668d2f4ed3b586 Cr-Commit-Position: refs/heads/master@{#35382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M tools/testrunner/local/execution.py View 3 chunks +0 lines, -5 lines 0 comments Download
M tools/testrunner/local/progress.py View 3 chunks +1 line, -10 lines 0 comments Download
M tools/testrunner/network/network_execution.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL
4 years, 8 months ago (2016-04-11 10:10:54 UTC) #3
Jakob Kummerow
lgtm
4 years, 8 months ago (2016-04-11 10:36:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874973003/1
4 years, 8 months ago (2016-04-11 10:39:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 11:59:58 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 12:00:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af1f78b80e083dc05a8632a804668d2f4ed3b586
Cr-Commit-Position: refs/heads/master@{#35382}

Powered by Google App Engine
This is Rietveld 408576698