Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1874933002: exo: Further improve ignored-by-shelf test. (Closed)

Created:
4 years, 8 months ago by reveman
Modified:
4 years, 8 months ago
Reviewers:
Daniele Castagna
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Further improve ignored-by-shelf test. Avoid test when we have pending configure requests and never let the shelf ignore windows unless maximized. This avoids having the state change twice when a window is being maximized. BUG=549781 TEST=exo_unittests TBR=dcastagna@chromium.org Committed: https://crrev.com/a56f16d1e111284a092d28ff79963302fd092e6a Cr-Commit-Position: refs/heads/master@{#386317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M components/exo/shell_surface.cc View 1 chunk +22 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
reveman
4 years, 8 months ago (2016-04-10 15:06:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874933002/1
4 years, 8 months ago (2016-04-10 15:07:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-10 16:00:58 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-10 16:02:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a56f16d1e111284a092d28ff79963302fd092e6a
Cr-Commit-Position: refs/heads/master@{#386317}

Powered by Google App Engine
This is Rietveld 408576698