ios/web/web_state/ui/crw_web_controller.h - Issue 1874903003: Reversed WebState <-> CRWWebController ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.h

Issue 1874903003: Reversed WebState <-> CRWWebController ownership. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.h

diff --git a/ios/web/web_state/ui/crw_web_controller.h b/ios/web/web_state/ui/crw_web_controller.h

index 582485dc52f35312f4353a8dde92a916dbeb91fd..205b9ec7d65b4ee64f3bee81b9efa24748820364 100644

--- a/ios/web/web_state/ui/crw_web_controller.h

+++ b/ios/web/web_state/ui/crw_web_controller.h

@@ -61,8 +61,7 @@ class WebStateImpl;

// CRWWebController also transparently evicts and restores the internal web

// view based on memory pressure, and manages access to interact with the

// web view.

-// This is an abstract class which must not be instantiated directly. A factory

-// function from web_controller_factory.h should be used instead.

+// This is an abstract class which must not be instantiated directly.

kkhorimoto 2016/04/12 21:36:13 Are we going to keep CRWWKWebViewWebController aro

Eugene But (OOO till 7-30) 2016/04/13 02:51:26 No. If you are worrying that this comment will rot

// TODO(stuartmorgan): Move all of the navigation APIs out of this class.

@interface CRWWebController : NSObject<CRWJSInjectionEvaluator,

CRWRequestTrackerDelegate,