ios/web/web_state/ui/crw_web_controller+protected.h - Issue 1874903003: Reversed WebState <-> CRWWebController ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller+protected.h

Issue 1874903003: Reversed WebState <-> CRWWebController ownership. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller+protected.h

diff --git a/ios/web/web_state/ui/crw_web_controller+protected.h b/ios/web/web_state/ui/crw_web_controller+protected.h

index a0ee53b6449c2f899e2816141eeebf7154ca19dd..00c111ab22643a392d60e87d2ef316fc48db68df 100644

--- a/ios/web/web_state/ui/crw_web_controller+protected.h

+++ b/ios/web/web_state/ui/crw_web_controller+protected.h

@@ -81,8 +81,8 @@ static NSString* const kScriptImmediateName = @"crwebinvokeimmediate";

// Downloader for PassKit files. Lazy initialized.

@property(nonatomic, readonly) CRWPassKitDownloader* passKitDownloader;

-// Designated initializer.

-- (instancetype)initWithWebState:(std::unique_ptr<web::WebStateImpl>)webState;

+// Designated initializer. Initializes web controller with unowned |webState|.

+- (instancetype)initWithWebState:(web::WebStateImpl*)webState;

// Creates a web view if it's not yet created.

- (void)ensureWebViewCreated;