Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: ios/web/public/web_controller_factory.h

Issue 1874903003: Reversed WebState <-> CRWWebController ownership. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged with origin/master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/ios_web.gyp ('k') | ios/web/public/web_controller_factory.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/web_controller_factory.h
diff --git a/ios/web/public/web_controller_factory.h b/ios/web/public/web_controller_factory.h
deleted file mode 100644
index e846762c60c36b12882be0fda4c04d4b9bcad41b..0000000000000000000000000000000000000000
--- a/ios/web/public/web_controller_factory.h
+++ /dev/null
@@ -1,32 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef IOS_WEB_PUBLIC_WEB_CONTROLLER_FACTORY_H_
-#define IOS_WEB_PUBLIC_WEB_CONTROLLER_FACTORY_H_
-
-#include <memory>
-
-@class CRWWebController;
-
-namespace web {
-
-class BrowserState;
-class WebStateImpl;
-
-// Returns a new instance of CRWWebViewController.
-// Note: Callers are responsible for releasing the returned web controller.
-CRWWebController* CreateWebController(std::unique_ptr<WebStateImpl> web_state);
-
-// Returns a new instance of CRWWebViewController.
-// Temporary factory method for use in components that require a web controller.
-// By requiring only the BrowserState, this eliminates the dependency on
-// WebStateImpl from components.
-// Note: Callers are responsible for releasing the returned web controller.
-// TODO(crbug.com/546221): Move factory method to WebState once the ownership of
-// WebState and CRWWebController is reversed.
-CRWWebController* CreateWebController(BrowserState* browser_state);
-
-} // namespace web
-
-#endif // IOS_WEB_PUBLIC_WEB_CONTROLLER_FACTORY_H_
« no previous file with comments | « ios/web/ios_web.gyp ('k') | ios/web/public/web_controller_factory.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698