Issue 18749004: Rename AllocationSite::payload to AllocationSite::transition_info

Issue 18749004: Rename AllocationSite::payload to AllocationSite::transition_info (Closed)

Created:
7 years, 5 months ago by mvstanton

Modified:
7 years, 5 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Rename AllocationSite::payload to AllocationSite::transition_info BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15556

Patch Set 3 : Addressed comments #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -48 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ast.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/builtins.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1 2	1 chunk	+10 lines, -11 lines	0 comments	Download
M	src/objects.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-printer.cc	View	1 2	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/runtime.cc	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Hannes, here is the TODO we discussed, to rename AllocationSite::payload. Thanks, --Michael

7 years, 5 months ago (2013-07-08 10:06:21 UTC) #1

Hannes Payer (out of office)

LGTM! 2 nits https://codereview.chromium.org/18749004/diff/1/src/objects-printer.cc File src/objects-printer.cc (right): https://codereview.chromium.org/18749004/diff/1/src/objects-printer.cc#newcode1122 src/objects-printer.cc:1122: PrintF(out, " - payload: "); payload ...

7 years, 5 months ago (2013-07-08 14:50:54 UTC) #2

mvstanton

Committed patchset #3 manually as r15556 (presubmit successful).

7 years, 5 months ago (2013-07-08 15:00:23 UTC) #3

mvstanton

7 years, 5 months ago (2013-07-08 15:06:31 UTC) #4

Message was sent while issue was closed.

right on, thanks. checkin' in.

https://codereview.chromium.org/18749004/diff/1/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/18749004/diff/1/src/objects-printer.cc#newcod...
src/objects-printer.cc:1122: PrintF(out, " - payload: ");
On 2013/07/08 14:50:55, Hannes Payer wrote:
> payload should be transition info

Done.

https://codereview.chromium.org/18749004/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/18749004/diff/1/src/objects.h#newcode7488
src/objects.h:7488: // If the payload is a smi, then it represents an
ElementsKind
On 2013/07/08 14:50:55, Hannes Payer wrote:
> payload -> transition info

Done.

Expand Messages | Collapse Messages